feat: Add (optional) forward linking of track states #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #2418 +/- ##
==========================================
+ Coverage 49.80% 49.81% +0.01%
==========================================
Files 466 466
Lines 26141 26190 +49
Branches 11989 12009 +20
==========================================
+ Hits 13019 13047 +28
- Misses 4615 4620 +5
- Partials 8507 8523 +16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Very nice, indeed! @EdwardMoyse you mind reviewing this one? |
This was referenced Sep 6, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 11, 2023
This was previously still using the `iprevious` member in `IndexData`, but we did have a separate `m_previous` column already that was being ignored. Preparation for #2418
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
This better indicates that the iterations is outside in Preparation for #2418.
A track can now initiate forward linking of its track states. The track states have a new property, `next` that optionally makes the sequence a doubly linked list. This is not filled by default (not even by `appendTrackState`) because for branching cases, it's not unambiguous. `linkForward()` on a track will initiate the forward linking and store the innermost track state index for easy access. `reverseTrackStates` also does this, since it's only valid for non-branching trackstate sequences anyway.
paulgessinger
force-pushed
the
track-state-range-order
branch
from
7231cc8 to
cd2e27e
Compare
|
Rebased, conflicts resolved. |
github-actions
bot
removed
Component - Examples
|
Conflicts resolved. |
AJPfleger
pushed a commit
to AJPfleger/acts
that referenced
this pull request
Sep 29, 2023
A track can now initiate forward linking of its track states. The track states have a new property, `next` that optionally makes the sequence a doubly linked list. This is not filled by default (not even by `appendTrackState`) because for branching cases, it's not unambiguous. `linkForward()` on a track will initiate the forward linking and store the innermost track state index for easy access. `reverseTrackStates` also does this, since it's only valid for non-branching trackstate sequences anyway. Also adds a `innermostTrackState()` getter, which returns a track state proxy in case the track is forward linked and has a `stemIndex` Blocked by: - acts-project#2425 - acts-project#2426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A track can now initiate forward linking of its track states. The track
states have a new property,
nextthat optionally makes the sequence adoubly linked list. This is not filled by default (not even by
appendTrackState) because for branching cases, it's not unambiguous.linkForward()on a track will initiate the forward linking and storethe innermost track state index for easy access.
reverseTrackStatesalso does this, since it's only valid for non-branching trackstate
sequences anyway.
Also adds a
innermostTrackState()getter, which returns a track state proxy in case the track is forward linked and has astemIndexBlocked by: