Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: #2318 (CKF material to target) after broken Athena integration tests #2321

Merged
merged 1 commit into from
Jul 27, 2023
Merged

revert: #2318 (CKF material to target) after broken Athena integration tests #2321

merged 1 commit into from
Jul 27, 2023

Conversation

andiwand
Copy link
Contributor

reverting after breaking Athena integration tests

@github-actions github-actions bot added Component - Core Affects the Core module Infrastructure Changes to build tools, continous integration, ... Component - Examples Affects the Examples module Track Finding Changes Performance labels Jul 27, 2023
@andiwand andiwand mentioned this pull request Jul 27, 2023
Merged
@andiwand andiwand changed the title Revert "fix: Use material towards target in CKF (#2318)" revert: fix: Use material towards target in CKF (#2318) Jul 27, 2023
@andiwand andiwand changed the title revert: fix: Use material towards target in CKF (#2318) revert: #2318 after broken Athena integration tests Jul 27, 2023
@andiwand andiwand added this to the next milestone Jul 27, 2023
@paulgessinger paulgessinger changed the title revert: #2318 after broken Athena integration tests revert: #2318 (CKF material to target_ after broken Athena integration tests Jul 27, 2023
@paulgessinger paulgessinger changed the title revert: #2318 (CKF material to target_ after broken Athena integration tests revert: #2318 (CKF material to target) after broken Athena integration tests Jul 27, 2023
@andiwand andiwand mentioned this pull request Jul 27, 2023
Merged
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #2321 (8a155f2) into main (8ff2bcd) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2321   +/-   ##
=======================================
  Coverage   49.47%   49.47%           
=======================================
  Files         451      451           
  Lines       25492    25484    -8     
  Branches    11726    11720    -6     
=======================================
- Hits        12612    12609    -3     
- Misses       4581     4582    +1     
+ Partials     8299     8293    -6
Files Changed Coverage Δ
...de/Acts/TrackFinding/CombinatorialKalmanFilter.hpp 32.07% <0.00%> (-0.11%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger paulgessinger modified the milestones: next, v28.0.0 Jul 27, 2023
@kodiakhq kodiakhq bot merged commit 1e2eb5d into acts-project:main Jul 27, 2023
@andiwand andiwand deleted the revert-2318 branch July 27, 2023 09:48
@github-actions
Copy link

📊 Physics performance monitoring for 8a155f2

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@acts-project-service
Copy link
Collaborator

acts-project-service commented Jul 27, 2023 •
edited
Loading

🔴 Athena integration test results

🔴 Some tests have failed!

Please investigate the pipeline!

status job
🟢 run_unit_tests
🔴 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsWorkflow.sh
🔴 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateTracks.sh
🔴 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsCoreSpacePoints.sh
🔴 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateActsSpacePoints.sh
🔴 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateSeeds.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateOrthogonalSeeds.sh
🔴 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsValidateClusters.sh
🟢 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsPersistifyEDM.sh
🔴 run_ci_tests: ../athena/AtlasTest/CITest/test/ActsKfRefitting.sh
🟢 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsExtrapolationAlgTest.py
🔴 run_ci_tests: python3 ../athena/Tracking/Acts/ActsGeometry/test/ActsITkTest.py
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jul 27, 2023
kodiakhq bot pushed a commit that referenced this pull request Sep 25, 2023
@andiwand
fix: Use material towards target in CKF (#2322)
ee6d693 
reopened #2318 after #2321

The CKF did not pick up the material in-between the first surface and the target surface. This PR is trying to fix that.

Note: I had to use a not so nice hack and call the navigation pre step routine before we step towards the target. I don't see an easy way around that.

blocked by
- #2336
AJPfleger pushed a commit to AJPfleger/acts that referenced this pull request Sep 29, 2023
@andiwand @AJPfleger
fix: Use material towards target in CKF (acts-project#2322)
6c47f62 
reopened acts-project#2318 after acts-project#2321

The CKF did not pick up the material in-between the first surface and the target surface. This PR is trying to fix that.

Note: I had to use a not so nice hack and call the navigation pre step routine before we step towards the target. I don't see an easy way around that.

blocked by
- acts-project#2336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
Changes Performance Component - Core Affects the Core module Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests Infrastructure Changes to build tools, continous integration, ... Track Finding
Projects
None yet
Milestone
v28.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andiwand @acts-project-service @paulgessinger