fix: Align globalToLocal and intersection in LineSurface

[andiwand]

This is supposed to be a proper fix after the quick fix in #2239

In globalToLocal we did not respect the direction which is important for the line surface.

I tried to make the code a little more clear and move away from constructor initialization in the mathy part. I also added a unit test to check the intersection against the propagation.

I will let the CI judge how much this breaks

[codecov]

Codecov Report

Merging #2287 (7224ca0) into main (1e2eb5d) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 19.17%.

❗ Current head 7224ca0 differs from pull request most recent head 5d5c343. Consider uploading reports for the commit 5d5c343 to get more accurate results

@@            Coverage Diff             @@
##             main    #2287      +/-   ##
==========================================
+ Coverage   49.47%   49.49%   +0.01%     
==========================================
  Files         451      451              
  Lines       25484    25469      -15     
  Branches    11720    11710      -10     
==========================================
- Hits        12609    12605       -4     
+ Misses       4582     4581       -1     
+ Partials     8293     8283      -10     

Files Changed	Coverage Δ
Core/include/Acts/Surfaces/LineSurface.hpp	100.00% <ø> (ø)
Core/src/Surfaces/LineSurface.cpp	35.37% <19.17%> (-0.43%)	⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊 Physics performance monitoring for 5d5c343

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu

IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

[andiwand]

thanks for the review @felix-russo !

[andiwand]

We're ready to go for v28 now. Can you update the PR so we can merge it?

should be ready now @paulgessinger

[paulgessinger]

Sorry maybe I'm dumb but from the diff it's not at all clear to me what's actually happening here. You're changing both intersect and globalToLocal, and they're not doing the same thing afterwards (and neither did they before I don't think).

What do we want globalToLocal to do (after this)? Check if we're on the line surface, or check if we're on the PCA?

[andiwand]

after #2321 the conflicts should disappear 🤞

[kodiakhq]

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

[acts-project-service]

🔴 Athena integration test results

Build job with this PR failed!

Please investigate the build job for the pipeline!

[paulgessinger]

Build failure is likely due to #2269, and not this PR. I'll update this PR once it's resolved.