feat: Track level improvements #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2012 +/- ##
==========================================
- Coverage 49.83% 49.79% -0.04%
==========================================
Files 415 416 +1
Lines 23593 23662 +69
Branches 10681 10721 +40
==========================================
+ Hits 11758 11783 +25
- Misses 4330 4338 +8
- Partials 7505 7541 +36
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Adds a central helper function that calculates number of holes, outliers, measurements and shared hits based on the type flags, and stores them in the track.
paulgessinger
force-pushed
the
track-calc
branch
from
dc367ad to
a162b2d
Compare
📊 Physics performance monitoring for 599a141Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
paulgessinger
commented
Apr 5, 2023
paulgessinger
commented
Apr 5, 2023
paulgessinger
commented
Apr 5, 2023
EdwardMoyse
approved these changes
Apr 6, 2023
paulgessinger
added a commit
to paulgessinger/acts
that referenced
this pull request
Apr 6, 2023
commit 98355e0 Author: Paul Gessinger <[email protected]> Date: Tue Apr 4 15:04:58 2023 +0200 doxygen commit a162b2d Author: Paul Gessinger <[email protected]> Date: Mon Apr 3 16:25:25 2023 +0200 fix wrong function commit 6021ea2 Author: Paul Gessinger <[email protected]> Date: Mon Apr 3 16:13:33 2023 +0200 unit test, append track state functionality commit 9a25c0a Author: Paul Gessinger <[email protected]> Date: Mon Apr 3 15:58:43 2023 +0200 some basic unit testing commit 83aa3e9 Author: Paul Gessinger <[email protected]> Date: Mon Apr 3 14:35:38 2023 +0200 feat: Fitters calculate track quantities Adds a central helper function that calculates number of holes, outliers, measurements and shared hits based on the type flags, and stores them in the track. commit 2235f82 Author: Paul Gessinger <[email protected]> Date: Mon Apr 3 14:21:25 2023 +0200 refactor: Changce TrackProxy chi2 method name commit aa6bc1d Author: Paul Gessinger <[email protected]> Date: Fri Mar 31 14:31:08 2023 +0200 add ndf and chi2 to track container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
appendTrackStatetoTrackProxy, allowing convenient building of track state chainsnOutliers,nSharedHits,chi2andnDoFto trackstrajectoryStateinMultiTrajectoryHelpers, but it stores the results on the tracks themselves.Closes #1999
Blocked by: