Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with track.nMeasurements() in CKF tracks #1999

Closed
pbutti opened this issue Mar 28, 2023 · 3 comments · Fixed by #2012
Closed

Issue with track.nMeasurements() in CKF tracks #1999

pbutti opened this issue Mar 28, 2023 · 3 comments · Fixed by #2012

Comments

@pbutti
Copy link
Contributor

pbutti commented Mar 28, 2023

When calling track.nMeasurements() on tracks reconstructed with the CKF, the return value is always 0.
@paulgessinger checked and confirmed that CKF doesn't fill this correctly (While KF and other fitters seem like they do)
@paulgessinger
Copy link
Member

So I guess the CKF should probably also loop over its tracks and calculate it.

@pbutti
Copy link
Contributor Author

pbutti commented Mar 30, 2023 •
edited
Loading

@paulgessinger will you take care? Alternatively you can point me to the relevant parts and I can take care of this. Also, perhaps we could add chi2sum and ndf to the TrackProxy?

@paulgessinger
Copy link
Member

I'll add it!

@paulgessinger paulgessinger mentioned this issue Apr 4, 2023
Merged
@kodiakhq kodiakhq bot closed this as completed in #2012 Apr 6, 2023
kodiakhq bot pushed a commit that referenced this issue Apr 6, 2023
@paulgessinger
feat: Track level improvements (#2012)
c4d019f 
This PR does a few things:

- Add a method `appendTrackState` to `TrackProxy`, allowing convenient building of track state chains
- Add properties `nOutliers`, `nSharedHits`, `chi2` and `nDoF` to tracks
- Adds a helper function that will calculate these values from the track states and store them on the track. That is similar to the already existing function `trajectoryState` in `MultiTrajectoryHelpers`, but it stores the results on the tracks themselves.
- The helper function is called by the 3 fitters and the CKF, so tracks should always have these numbers.

Closes #1999

Blocked by:

- #2007
- #2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Track level improvements paulgessinger/acts
2 participants
@paulgessinger @pbutti