-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add TrajectoryPrinter helper algorithm #1854
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1854 +/- ##
=======================================
Coverage 49.50% 49.50%
=======================================
Files 407 407
Lines 22646 22646
Branches 10334 10334
=======================================
Hits 11210 11210
Misses 4247 4247
Partials 7189 7189 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 8d0c26eFull report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good just left one question
s.addAlgorithm( | ||
acts.examples.TrajectoryPrinter( | ||
level=customLogLevel(), | ||
inputTrajectories=trackFinder.config.outputTrajectories, | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we hide this behind a flag or just have it switching on with the correct debug level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, could do I guess.
On second thought, maybe we don't actually need to put this in. |
This PR adds a helper algorithm that prints out Trajectories. I'm using this to debug. It might not be useful for a long time, but I thought it might make sense to add it at this point in time anyway.