Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add TrajectoryPrinter helper algorithm #1854

Closed

Conversation

paulgessinger
Copy link
Member

This PR adds a helper algorithm that prints out Trajectories. I'm using this to debug. It might not be useful for a long time, but I thought it might make sense to add it at this point in time anyway.

@paulgessinger paulgessinger added this to the next milestone Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #1854 (8d0c26e) into main (97a8458) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1854   +/-   ##
=======================================
  Coverage   49.50%   49.50%           
=======================================
  Files         407      407           
  Lines       22646    22646           
  Branches    10334    10334           
=======================================
  Hits        11210    11210           
  Misses       4247     4247           
  Partials     7189     7189           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Feb 10, 2023

📊 Physics performance monitoring for 8d0c26e

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just left one question

Comment on lines +884 to +889
s.addAlgorithm(
acts.examples.TrajectoryPrinter(
level=customLogLevel(),
inputTrajectories=trackFinder.config.outputTrajectories,
)
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we hide this behind a flag or just have it switching on with the correct debug level?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, could do I guess.

@paulgessinger
Copy link
Member Author

On second thought, maybe we don't actually need to put this in.

kodiakhq bot pushed a commit that referenced this pull request Feb 14, 2023
)

This removes the `Trajectories` output writing, completely moving to the separate conversion algorithm introduced in #1857

Blocked by:
- #1854
- #1839 
- #1857
@paulgessinger paulgessinger modified the milestones: next, v23.3.0 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants