refactor: Trajectories stores MultiTrajectory pointer #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires writing the tracks to the white board so the track state container stays alive after the algorithm ends.
📊 Physics performance monitoring for f3ef83aFull report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
Codecov Report
@@ Coverage Diff @@
## main #1839 +/- ##
=======================================
Coverage 49.50% 49.50%
=======================================
Files 407 407
Lines 22646 22646
Branches 10334 10334
=======================================
Hits 11210 11210
Misses 4247 4247
Partials 7189 7189 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Feb 13, 2023
andiwand
approved these changes
Feb 13, 2023
Examples/Algorithms/TrackFinding/include/ActsExamples/TrackFinding/TrackFindingAlgorithm.hpp
Show resolved
Hide resolved
...orithms/TrackFittingChi2/include/ActsExamples/TrackFittingChi2/TrackFittingChi2Algorithm.hpp
Show resolved
Hide resolved
Co-authored-by: Andreas Stefl <[email protected]>
|
Applied suggestions, can you reapprove @andiwand? |
andiwand
approved these changes
Feb 13, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 14, 2023
Add a dedicated conversion algorithm from tracks to trajectories. Blocked by: - #1839 Co-authored-by: Louis-Guillaume Gagnon <[email protected]> Co-authored-by: Pierfrancesco Butti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to be able to write a general tracks to trajectories converter.
This requires writing the tracks to the white board so the track state container stays alive after the algorithm ends.
Blocked by: