Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stale labels and ignore stale issues with comments #58

Merged
merged 6 commits into from
May 11, 2020
Merged

Remove stale labels and ignore stale issues with comments #58

merged 6 commits into from
May 11, 2020

Conversation

hross
Copy link
Contributor

@hross hross commented May 2, 2020 •
edited
Loading

Addresses #21: Ignore issues that have comments on them

  • Check each issue for comments since the stale label was applied. If they exist, don't close the issue.
  • Add an option to allow the stale label to be removed by the bot (off by default)

TODO:

  1. Fix failing tests
  2. (optional) Make the method injection for the test suite less burdensome (mocking or a fake client)
  3. Add more tests
  4. Test this logic on some real repos

@hross hross mentioned this pull request May 2, 2020
Closed
@donavanbecker
Copy link

@shawnnapora can we get this merged?

damccorm
damccorm approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally LGTM

@hross
Copy link
Contributor Author

hross commented May 4, 2020

I still need to fix the failing tests and the other TODOs before I can merge this

@hross hross merged commit 3838b88 into master May 11, 2020
@AshCripps AshCripps mentioned this pull request Jul 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donavanbecker donavanbecker donavanbecker approved these changes

@damccorm damccorm damccorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hross @donavanbecker @damccorm