New comments do not remove the Stale label

[gergelyke]

As raised in uber/baseweb#1892, it seems like new comments do not remove the Stale label. Do we miss anything in our configuration?

name: 'Close stale issues'
on:
  schedule:
    - cron: '0 0 * * *'

jobs:
  stale:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/stale@v1
        with:
          repo-token: ${{ secrets.GITHUB_TOKEN }}
          stale-issue-message: "This issue is stale because it has been open 30 days with no activity. If it's still valid, please remove the stale label or comment on the issue, otherwise this ticket will be closed in 5 days"
          days-before-stale: 30
          days-before-close: 5

[LekoArts]

I'd also be interested in knowing if this is a bug or user error.

[m-allanson]

It looks like this feature hasn't (yet 😄) been implemented in the action. Is this a feature that would be accepted?

[eileenmcnaughton]

I am +1 on that feature being useful!

[homotechsual]

Also +1 on the feature being useful :-)

[LekoArts]

@gergelyke @eileenmcnaughton @MikeyMJCO
I've implemented this feature in our fork here: https://github.com/gatsbyjs/stale/blob/128ed907d5174a32717e7761e63294f5c747d8e2/src/main.ts#L122-L130

It lists all comments since the "days-before-stale" and filters for bot/user comments. If it can find user comments, the resulting array is not empty and hence the function return true.

[ruudk]

@LekoArts so cool, did you consider proposing this as a PR to this repo? Would love this to be standard feature ❤️

[eileenmcnaughton]

Agree - this needs to be a standard feature before the main feature is usable

[LekoArts]

I changed the logic in the meantime to a more robust way of checking it: https://github.com/gatsbyjs/stale/blob/gatsby-refactoring/src/main.ts#L143

This is all WIP so use it at your own risk, we're still testing ourselves. And if they maintain the repository again and would accept a PR we gladly would PR that upstream.

[eileenmcnaughton]

Hmm so the upstream repo is not maintained anymore :-(

[TheSalesOpsGuy]

Were you ever able to merge your fork/updates into the main action? I'm trying to get the old probot functionality back as well (remove label if commented).

[LekoArts]

You can use our fork if you want: https://github.com/gatsbyjs/stale
It's been working great for us. Since the repo still seems inactive a PR seems unfeasible - we'd be happy to send it in though.

[Tejas2805]

Hi,

Any way to stop issues from closing?

[dev-zero]

It would be nice if it could then also remove other labels as well. Our use case is that we would like to only have stale-handling for issues marked with needinfo. In case of a comment both needinfo and stale labels should be removed.

[hross]

I agree this should be done. I'll add it to the list (I'm actively reviving this repo since it was somewhat stale a while ago).

[ramnes]

Just discovering this and yeah, it's much needed, because if users are not able to stop the countdown, then as a maintainer I'd probably want the issue to be closed right away instead.

[TheSalesOpsGuy]

Just discovering this and yeah, it's much needed, because if users are not able to stop the countdown, then as a maintainer I'd probably want the issue to be closed right away instead.

I think the issue is just that the label isn't cleared, the script still checks for the last updated date on the issue so a user commenting resets the counter, it just doesn’t also clear the flag (which may or may not be a good thing depending on how you like your labels to work)

[hross]

@damccorm PR is up over here (not quite working yet): #58 if you want to review it

[Gustry]

FYI #58 has been merged. You can try again.

[homotechsual]

This is working for us now.

[Tejas2805]

Still doesn't work for me. My configuration makes it runs every min, still.

[homotechsual]

Still doesn't work for me. My configuration makes it runs every min, still.

Can you link your repo?

[Tejas2805]

Still doesn't work for me. My configuration makes it runs every min, still.

Can you link your repo?

https://github.com/Tejas2805/Github-Actions

[homotechsual]

Can you try adding remove-stale-when-updated: 'True' to your yml file.

[homotechsual]

You also have to factor in that it will only run on a limited number of issues/PR per run and so it may take a few runs to get to the changes.

[homotechsual]

Ah - nvm - found it. It's ignoring your comments.

[homotechsual]

Comments not made by Tejas2805 or another bot: 0

https://github.com/Tejas2805/Github-Actions/runs/853183570?check_suite_focus=true

[homotechsual]

Try with a comment made by someone else!

[Tejas2805]

Any reason? Cause the PR is made by me.

[homotechsual]

Yeah - it ignores the author from what I can see!

[homotechsual]

I made a comment to test - if you can increase the frequency of your runs again!

[homotechsual]

And nevermind - it ran and remove the label!

[Tejas2805]

Any way to make it remove when the author comments? Cause I think the "stale" part comes from the fact that the author is not active on it.

[homotechsual]

Okay so the answer is yes, it ignores github.context.actor which is the user who setup/runs the GitHub action.

So it's not ignoring you because you're the author, it's ignoring you because you run the action!

[Tejas2805]

So it's not ignoring you because you're the author, it's ignoring you because you run the action!

Ah! Makes sense. Thank you for your help.

[homotechsual]

@hross I'm gonna suggest that you close this issue now if that seems appropriate? It's original issue has been addressed!

[rdxmb]

Does this problem still exist? See helm/helm#4262 (comment)

[bridgetkromhout]

Does this problem still exist? See helm/helm#4262 (comment)

@rdxmb The helm/helm repo stale issue action (https://github.com/helm/helm/actions?query=workflow%3A%22Close+stale+issues%22) runs once per day, not on-demand. So you'll see if you re-check that issue that you did indeed get the issue marked as not-stale - it just wasn't instant.