Skip to content
This repository was archived by the owner on Nov 16, 2021. It is now read-only.

Building front end assets with composer. #131

Closed
wants to merge 3 commits into from

Conversation

grasmash
Copy link
Contributor

No description provided.

@grasmash
Copy link
Contributor Author

Hey hey! It worked!

@danepowell
Copy link
Contributor

I think composer.lock needs to be updated

@danepowell
Copy link
Contributor

Matt points out that even if composer.lock were updated, this upstream issue would be a blocker:
fxpio/composer-asset-plugin#7

@@ -137,6 +140,11 @@
"drupal/entity_browser": "8.1.0-alpha3",
"drupal/views_infinite_scroll": "8.1.0",
"drupal/media_entity_document": "^8.1.0",
"drupal/video_embed_field": "^8.1.0"
"drupal/video_embed_field": "^8.1.0",
"fxp/composer-asset-plugin": "dev-master#b2cc94c8018a7f4d61d1e0ab0d211a2713daa4fe",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composer doesn't let you pull specific commit hashes for dependencies of dependencies. So when lightning is a dependency of BLT or Lightning Project, this won't work.

Can you pull 1.1.4 and patch whatever functionality is missing?

@grasmash grasmash closed this Jun 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants