Skip to content
This repository was archived by the owner on Nov 16, 2021. It is now read-only.

Adding front end assets to composer.json. #119

Closed
wants to merge 1 commit into from

Conversation

grasmash
Copy link
Contributor

@grasmash grasmash commented Apr 26, 2016

Currently, simply using composer to install lightning will not build the front end dependencies. Drush make must be used, or npm install must be called from the lightning directory. This causes automated tests to fail.

This PR uses composer to manage front end dependencies.

@grasmash
Copy link
Contributor Author

A few notes:

  • This PR relies on Prevent fatal str_pos() error in dist parsing. fxpio/composer-asset-plugin#216 being merged upstream
  • This notably slows down composer builds, at least on the first run. This is due to npm package information being downloaded. It is cached and subsequent builds are faster.
  • We do not have a mechanism to ignore recursive dependencies, such as jquery, jqueryui, and backbone.
  • I believe this allows us to remove code. Namely the bower.json file, possibly package.json, and a few Phing targets.

@grasmash
Copy link
Contributor Author

grasmash commented May 4, 2016

fxpio/composer-asset-plugin#216 has been merged upstream. @balsama Can you restart travis tests and see if we get a pass?

@balsama
Copy link
Contributor

balsama commented May 5, 2016

@grasmash
Copy link
Contributor Author

grasmash commented May 5, 2016

One more time? :p

@balsama
Copy link
Contributor

balsama commented May 10, 2016

@grasmash
Copy link
Contributor Author

Very strange, it's claiming that the underscore package being downloaded is corrupt. Download the same package locally for me is fine. Not sure what would cause that.

@grasmash
Copy link
Contributor Author

@balsama
Copy link
Contributor

balsama commented May 10, 2016

hmmm. and PR #119 doesn't have a cache on travis - presumably because it never finished?

@danepowell
Copy link
Contributor

See #129 and #131

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants