Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Adding patches and tmp to deploy excludes #362

Merged
merged 3 commits into from
Sep 7, 2016

Conversation

dpagini
Copy link
Contributor

@dpagini dpagini commented Sep 6, 2016

Not sure if all of these are appropriate, but wanted to open for discussion.

  • Exclude /scripts directory
    • I believe these are all dev support scripts and would not be used in the artifact. I could be wrong here though?
  • Exclude /patches directory
    • Patches get applied in $ composer install command, meaning the folder is a remnant of the source code.
  • Exclude /tmp directory
    • Not sure where this get used, but have found it in my project a few times. It's .gitignore'd, so I can't imagine we would want it in our build artifact.

A few other thoughts...

  • I don't know if there is a recommended place to put blt overrides (phing, etc.), but we have them in /blt/custom, so I exclude the /blt directory. If that is recommended in the docs as best practice, maybe that folder should be excluded (similar to excluding the /box directory.
  • Should/could all README.md files be excluded from the build artifact? Probably not, but that's something I do.

[edit] realizing that /scripts is a remnant of pre-composer blt architecture.

* Exclude `/scripts` directory
* Exclude `/patches` directory
* Exclude `/tmp` directory
Realizing this is a remnant of the pre-composer acquia/blt.
@grasmash grasmash merged commit 26d659f into acquia:8.x Sep 7, 2016
@grasmash grasmash changed the title Deploy excludes Adding patches and tmp to deploy excludes Sep 9, 2016
@grasmash grasmash added the Enhancement A feature or feature request label Sep 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants