[WIP] Create user and login with password #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flow check happy
chore(flow): Added type declarations for accounts and made eslint and flow check happy
Circleci yarn
Server side Accounts.createUser
* Setup jest
grantga
reviewed
Jan 11, 2017
| const nextState = state; | ||
| switch (action.type) { | ||
| case LOGIN: { | ||
| break; |
There was a problem hiding this comment.
Good call. The LOGINcase can be removed. SET_USER still needs to be filled out for reactivity in the ui when the user is logged in.
alexyuly
suggested changes
Jan 12, 2017
| return this.instance.addEmail(userId, newEmail, verified); | ||
| }, | ||
| removeEmail(userId: string, newEmail: string): Promise<void> { | ||
| return this.instance.addEmail(userId, newEmail); |
There was a problem hiding this comment.
Should this be this.instance.removeEmail?
There was a problem hiding this comment.
Eagle eye. Good catch. Will fix.
| return this.instance.addEmail(userId, newEmail); | ||
| }, | ||
| verifyEmail(userId: string, email: string): Promise<void> { | ||
| return this.instance.addEmail(userId, email); |
…dded reduxLogger to client config to allow logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My apologies for the giant PR.
This PR introduces the core accounts package. It provides the client and server side logic for user creation and authentication.