chore(flow): Added type declarations for accounts and made eslint and flow check happy #23
+106
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flow check happy
davidyaha
force-pushed
the
improve-flow
branch
from
f656895 to
242d8db
Compare
|
@davidyaha This looks solid, thanks for picking up where I left off. |
|
@davidyaha Merge at your leisure. |
|
Cool I would love to but I don't have write access to this package for some reason. |
|
@davidyaha, the permisisons have been fixed, sorry about that. Merging this PR. |
Aetherall
pushed a commit
that referenced
this pull request
Mar 11, 2018
case insensitive user name query
Aetherall
pushed a commit
that referenced
this pull request
Mar 13, 2018
case insensitive user name query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to accelerate and get some feedback on the flow typings.
@TimMikeladze I branched off from your flow branch.
Hopefully everything was pushed and there is no merges.. anyhow, let me know if that's the case and I'll work on the necessary changes.