Add new license Anti-Capitalist Software License #2362 #2364

sritasngh · 2021-01-12T13:39:56Z

Signed-off-by: itssingh [email protected]
Fixes #2362

Added new licenses ANTI-CAPITALIST SOFTWARE LICENSE v-1.0, v-1.1, v-1.2, v-1.3 and v-1.4

These added licenses are giving correct scan result.

Reviewed contribution guidelines
PR is descriptively titled 📑 and links the original issue above 🔗
Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
Run tests locally to check for errors.
Commits are in uniquely-named feature branch and has no merge conflicts 📁

pombredanne

Thanks! I have a few nitpickings for your consideration before we can merge.

src/licensedcode/data/licenses/anti-capitalist-1.0.LICENSE

src/licensedcode/data/licenses/anti-capitalist-1.0.yml

src/licensedcode/data/licenses/anti-capitalist-1.1.LICENSE

src/licensedcode/data/licenses/anti-capitalist-1.2.LICENSE

src/licensedcode/data/licenses/anti-capitalist-1.3.LICENSE

src/licensedcode/data/licenses/anti-capitalist-1.2.yml

src/licensedcode/data/licenses/anti-capitalist-1.2.LICENSE

src/licensedcode/data/licenses/anti-capitalist-1.1.yml

src/licensedcode/data/licenses/anti-capitalist-1.1.LICENSE

pombredanne

@itssingh Thank you! Almost there too here!

See the "ignorables"-related test failures in https://dev.azure.com/nexB/scancode-toolkit/_build/results?buildId=3262&view=logs&j=3c16b29b-eb82-5c7a-26ca-153f5e2ef8d4&t=525ae439-c19a-5d45-abf1-df81b3df2f93&l=43551 for your review.

sritasngh · 2021-03-30T04:05:21Z

See the "ignorables"-related test failures

should I put url in notes: ?

pombredanne

should I put url in notes:

no, you just need to add ignorable_* fields for URLs and emails

src/licensedcode/data/licenses/anti-capitalist-1.4.yml

src/licensedcode/data/rules/anti_capitalist1.yml

pombredanne

Thank you! Please consider the few cleanups I suggested. Also feel free to squash all your commits in a single one.

src/licensedcode/data/licenses/anti-capitalist-1.4.yml

src/licensedcode/data/rules/anti_capitalist1.yml

src/licensedcode/data/rules/anti_capitalist2.yml

src/licensedcode/data/rules/anti_capitalist3.yml

src/licensedcode/data/rules/anti_capitalist4.yml

sritasngh · 2021-06-04T00:33:56Z

consider the few cleanups I suggested

I left these #2364 (comment) as trailing line return #2364 (comment) as you previously suggested. Removed now :)

Signed-off-by: Philippe Ombredanne <[email protected]>

Bump commoncode

Update CONTRIBUTING.rst Authored-by: Abhigya Verma<[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>

…ocumentnamespace

Signed-off-by: Philippe Ombredanne <[email protected]>

Format code. Refactor common code between RDF and TV. Signed-off-by: Philippe Ombredanne <[email protected]>

Signed-off-by: Philippe Ombredanne <[email protected]>

…utilities

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>

Signed-off-by: akugarg <[email protected]>

Add new flag in License Data Model definition

Some instructions were not (exactly) right, and some commands are now also highlighted properly. Signed-off-by: Marcel Rettig <[email protected]>

…ting Update Contributing: Development setup-instructions Signed-off-by: Marcel Rettig <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>

sritasngh · 2021-08-10T09:51:37Z

@pombredanne Should I add notes for all the rules?

Signed-off-by: akugarg <[email protected]>

Referenced_filenames should be returned by API function

This provides a rule that matches MIT notices of form (note: indent for highlight): License This project is licensed under the terms of the MIT license. Signed-off-by: Peter Gardfjäll <[email protected]>

This avoids Apache-2.0 "overriding" mit_349.RULE in cases like ## License This project is licensed under the terms of the MIT license. Signed-off-by: Peter Gardfjäll <[email protected]>

Add emails and urls in converted_infos. Add holders, authors, emails and urls information in html template. Signed-off-by: Sarita Singh <[email protected]> Co-authored-by: Avinal Kumar <[email protected]>

Signed-off-by: Sarita Singh <[email protected]> Co-authored-by: Avinal Kumar <[email protected]>

Add emails and urls to HTML output

Avoid misinterpreting MIT license notice as Apache-2.0, issue aboutcode-org#2635

Signed-off-by: akugarg <[email protected]>

Add final report for GSoC'21

This version check causes problems when running in a firewalled environment (in my case, hanging for 30 seconds before timing out). This just adds a CLI option to skip it entirely. Signed-off-by: Yunus Rahbar <[email protected]>

Add "--no-check-version" CLI option to scancode

Align tests for pubspec with latest code

Add new licenses

Somehow a tab had squeezed in Signed-off-by: Philippe Ombredanne <[email protected]>

This is no longer supported in newest Python versions. Signed-off-by: Philippe Ombredanne <[email protected]>

pombredanne · 2021-08-25T08:49:05Z

FYI I merged the latest develop and fixed the tests, then pushed back to your branch

pombredanne

LGTM. Merging now at last. Thanks!

sritasngh force-pushed the anti-capitalist branch from 97f12d5 to acd528a Compare January 20, 2021 11:57

pombredanne requested changes Feb 26, 2021

View reviewed changes

sritasngh force-pushed the anti-capitalist branch 2 times, most recently from cae78e2 to f691361 Compare March 2, 2021 13:32

sritasngh requested a review from pombredanne March 13, 2021 14:44

sritasngh force-pushed the anti-capitalist branch from f691361 to 31c8888 Compare March 26, 2021 19:45

pombredanne changed the title ~~Added new license Anti-Capitalist Software License #2362~~ Add new license Anti-Capitalist Software License #2362 Mar 29, 2021

pombredanne requested changes Mar 29, 2021

View reviewed changes

pombredanne reviewed Jun 2, 2021

View reviewed changes

sritasngh force-pushed the anti-capitalist branch from 31c8888 to da309e6 Compare June 3, 2021 10:12

sritasngh requested a review from pombredanne June 3, 2021 10:57

pombredanne requested changes Jun 3, 2021

View reviewed changes

sritasngh force-pushed the anti-capitalist branch from da309e6 to 1004243 Compare June 4, 2021 00:28

sritasngh requested a review from pombredanne June 4, 2021 01:26

pombredanne and others added 14 commits June 16, 2021 15:32

Bump commoncode

729d5d6

Signed-off-by: Philippe Ombredanne <[email protected]>

Merge pull request aboutcode-org#2557 from nexB/bump-commoncode

ce169cf

Bump commoncode

Merge pull request aboutcode-org#2375 from abhi27-web/patch-1

5c7208a

Update CONTRIBUTING.rst Authored-by: Abhigya Verma<[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>

Merge remote-tracking branch 'upstream/develop' into alpianon-patch-d…

16914ae

…ocumentnamespace

Add CHANGELOG entry for SPDX format update

451f883

Signed-off-by: Philippe Ombredanne <[email protected]>

Streamline SPDX formatting code aboutcode-org#2344

219ac9f

Format code. Refactor common code between RDF and TV. Signed-off-by: Philippe Ombredanne <[email protected]>

Update SPDX test expectatations aboutcode-org#2344

6c7c024

Signed-off-by: Philippe Ombredanne <[email protected]>

Use correct pytest setting for markers

1029068

Signed-off-by: Philippe Ombredanne <[email protected]>

Clarify function to extract data from wheel name

d621379

Signed-off-by: Philippe Ombredanne <[email protected]>

Merge remote-tracking branch 'pip2pi/master' into improve-thirdparty-…

f93558e

…utilities

Add rules to improve debian-slim license detection

035d643

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>

Regenerate tests after adding rules

9ae88d5

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>

Add is_unknown flag for license class

a451a9c

Signed-off-by: akugarg <[email protected]>

Add is_unknown flag to data files of unknown licenses

e62be42

Signed-off-by: akugarg <[email protected]>

pombredanne and others added 3 commits August 6, 2021 15:37

Merge pull request aboutcode-org#2548 from akugarg/add_new_flag

0dd52df

Add new flag in License Data Model definition

Update Contributing: Development setup-instructions

575c182

Some instructions were not (exactly) right, and some commands are now also highlighted properly. Signed-off-by: Marcel Rettig <[email protected]>

Merge pull request aboutcode-org#2631 from mapelpapel/update-contribu…

b7d070f

…ting Update Contributing: Development setup-instructions Signed-off-by: Marcel Rettig <[email protected]> Signed-off-by: Philippe Ombredanne <[email protected]>

akugarg and others added 22 commits August 10, 2021 23:29

return referenced_filenames for licenses matches

a705382

Signed-off-by: akugarg <[email protected]>

Update test cases upto expectations

ef8b217

Signed-off-by: akugarg <[email protected]>

Merge pull request aboutcode-org#2632 from akugarg/update_api

daeb709

Referenced_filenames should be returned by API function

adds MIT detection rule 1055

1bab112

This provides a rule that matches MIT notices of form (note: indent for highlight): License This project is licensed under the terms of the MIT license. Signed-off-by: Peter Gardfjäll <[email protected]>

apache-2.0_328.RULE: set minimum_coverage to 70

0632f33

This avoids Apache-2.0 "overriding" mit_349.RULE in cases like ## License This project is licensed under the terms of the MIT license. Signed-off-by: Peter Gardfjäll <[email protected]>

Add emails and urls

75a744f

Add emails and urls in converted_infos. Add holders, authors, emails and urls information in html template. Signed-off-by: Sarita Singh <[email protected]> Co-authored-by: Avinal Kumar <[email protected]>

Add test for sample HTML template and update changelog

b7e35b7

Signed-off-by: Sarita Singh <[email protected]> Co-authored-by: Avinal Kumar <[email protected]>

Merge pull request aboutcode-org#2539 from itssingh/html_temp

41d2d5b

Add emails and urls to HTML output

Merge pull request aboutcode-org#2636 from petergardfjall/issue-2635

6bf2fd9

Avoid misinterpreting MIT license notice as Apache-2.0, issue aboutcode-org#2635

Add new talis community license

50b4fcc

Signed-off-by: akugarg <[email protected]>

Merge branch 'nexB:develop' into add_new_licenses

5ec3144

Update test cases upto expectations

d954e40

Signed-off-by: akugarg <[email protected]>

Add final report for GSoC'21

b51e281

Signed-off-by: akugarg <[email protected]>

Merge pull request aboutcode-org#2648 from akugarg/final_report

3be07db

Add final report for GSoC'21

Merge branch 'develop' into 2110-dart-pubspec

0a4972e

Add "--no-check-version" CLI option to scancode

23c8ef0

This version check causes problems when running in a firewalled environment (in my case, hanging for 30 seconds before timing out). This just adds a CLI option to skip it entirely. Signed-off-by: Yunus Rahbar <[email protected]>

Merge pull request aboutcode-org#2662 from yns88/no-check-version

f7b3a93

Add "--no-check-version" CLI option to scancode

Merge pull request aboutcode-org#2628 from nexB/2110-dart-pubspec

1cfe28f

Align tests for pubspec with latest code

Merge pull request aboutcode-org#2625 from akugarg/add_new_licenses

884f829

Add new licenses

Merge remote-tracking branch 'itssingh/anti-capitalist' into develop

e18f389

Remove trailing tab from license data files

c79c0ec

Somehow a tab had squeezed in Signed-off-by: Philippe Ombredanne <[email protected]>

Do not use encoding with json.loads

2da1247

This is no longer supported in newest Python versions. Signed-off-by: Philippe Ombredanne <[email protected]>

pombredanne approved these changes Aug 25, 2021

View reviewed changes

pombredanne merged commit 3a82423 into aboutcode-org:develop Aug 25, 2021

sritasngh deleted the anti-capitalist branch October 9, 2021 12:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new license Anti-Capitalist Software License #2362 #2364

Add new license Anti-Capitalist Software License #2362 #2364

sritasngh commented Jan 12, 2021 •

edited by pombredanne

Loading

pombredanne left a comment

pombredanne left a comment

sritasngh commented Mar 30, 2021 •

edited

Loading

pombredanne left a comment

pombredanne left a comment

sritasngh commented Jun 4, 2021

sritasngh commented Aug 10, 2021

pombredanne commented Aug 25, 2021

pombredanne left a comment

Add new license Anti-Capitalist Software License #2362 #2364

Add new license Anti-Capitalist Software License #2362 #2364

Conversation

sritasngh commented Jan 12, 2021 • edited by pombredanne Loading

These added licenses are giving correct scan result.

pombredanne left a comment

Choose a reason for hiding this comment

pombredanne left a comment

Choose a reason for hiding this comment

sritasngh commented Mar 30, 2021 • edited Loading

pombredanne left a comment

Choose a reason for hiding this comment

pombredanne left a comment

Choose a reason for hiding this comment

sritasngh commented Jun 4, 2021

sritasngh commented Aug 10, 2021

pombredanne commented Aug 25, 2021

pombredanne left a comment

Choose a reason for hiding this comment

sritasngh commented Jan 12, 2021 •

edited by pombredanne

Loading

sritasngh commented Mar 30, 2021 •

edited

Loading