Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "--no-check-version" CLI option to scancode #2662

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

yns88
Copy link
Contributor

@yns88 yns88 commented Aug 24, 2021

This version check causes problems when running in a firewalled environment (in my case, hanging for 30 seconds before timing out). This just adds a CLI option to skip it entirely.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

@yns88 yns88 force-pushed the no-check-version branch 3 times, most recently from 2b87de9 to ab57d6f Compare August 24, 2021 15:52
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you ++ for this. This makes 100% sense.

src/scancode/cli.py Show resolved Hide resolved
This version check causes problems when running in a firewalled environment (in my case, hanging for 30 seconds before timing out). This just adds a CLI option to skip it entirely.

Signed-off-by: Yunus Rahbar <[email protected]>
@yns88 yns88 force-pushed the no-check-version branch from ab57d6f to 23c8ef0 Compare August 24, 2021 16:55
@pombredanne
Copy link
Member

All green! 💚 Thanks! merging.

@pombredanne pombredanne merged commit f7b3a93 into aboutcode-org:develop Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants