Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEM] (deps-dev): Bump rubocop from 1.66.1 to 1.69.1 #84

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 3, 2024

Bumps rubocop from 1.66.1 to 1.69.1.

Release notes

Sourced from rubocop's releases.

RuboCop 1.69.1

Bug fixes

  • #13502: Fix an incorrect autocorrect for Style/DigChain when using safe navigation method chain with dig method. (@​koic)
  • #13505: Fix an error for Style/ParallelAssignment when using the anonymous splat operator. (@​earlopain)
  • #13184: Fix some false positives in Lint/UnreachableCode. (@​isuckatcs)
  • #13494: Fix false positives for Style/HashExcept cop when using reject/!include?, reject/!in? or select/!exclude? combinations. (@​lovro-bikic)
  • #13522: Fix Lint/UnescapedBracketInRegexp cop failure with invalid regular expression. (@​viralpraxis)
  • #13523: Fix Style::AccessModifierDeclarations cop failure in case of if node without else. (@​viralpraxis)
  • #13524: Fix Style/RedundantArgument cop failure while inspecting string literal with invalid encoding. (@​viralpraxis)
  • #13528: Fix Style/RedundantParentheses cop failure in case of splatted case node without condition. (@​viralpraxis)
  • #13521: Fix Style/RedundantSelf cop failure with kwnilarg argument node. (@​viralpraxis)
  • #13526: Fix Style/StringConcatenation cop failure when there are mixed implicit and explicit concatenations. (@​viralpraxis)
  • #13511: Fix false positive in Lint/UnescapedBracketInRegexp when using regexp_parser 2.9.2 and earlier. (@​dvandersluis)
  • #13096: Update Style/BlockDelimiters to not change braces when they are required for syntax. (@​dvandersluis)
  • #13512: Update Style/LambdaCall to be aware of safe navigation. (@​dvandersluis)

RuboCop 1.69

New features

Bug fixes

  • #13455: Fix a false positive for Layout/EmptyLineAfterGuardClause when using a guard clause outside oneliner block. (@​koic)
  • #13412: Fix a false positive for Style/RedundantLineContinuation when there is a line continuation at the end of Ruby code followed by __END__ data. (@​koic)
  • #13476: Allow to write generics type of RBS::Inline annotation after subclass definition in Style/CommentedKeyword. ([@​dak2][])
  • #13441: Fix an incorrect autocorrect for Style/IfWithSemicolon when using return with value in if with a semicolon is used. (@​koic)
  • #13448: Fix an incorrect autocorrect for Style/IfWithSemicolon when the then body contains an arithmetic operator method call with an argument. (@​koic)
  • #13199: Make Style/RedundantCondition skip autocorrection when a branch has a comment. (@​koic)
  • #13411: Fix Style/BitwisePredicate when having regular method. ([@​d4be4st][])
  • #13432: Fix false positive for Lint/FloatComparison against nil. (@​lovro-bikic)
  • #13461: Fix false positives for Lint/InterpolationCheck when using invalid syntax in interpolation. (@​koic)
  • #13402: Fix a false positive for Lint/SafeNavigationConsistency when using unsafe navigation with both && and ||. (@​koic)
  • #13434: Fix a false positive for Naming/MemoizedInstanceVariableName for assignment methods`. (@​earlopain)
  • #13415: Fix false positives for Naming/MemoizedInstanceVariableName when using initialize_clone, initialize_copy, or initialize_dup. (@​koic)
  • #13421: Fix false positives for Style/SafeNavigation when using a method chain that exceeds the MaxChainLength value and includes safe navigation operator. (@​koic)
  • #13433: Fix autocorrection for Style/AccessModifierDeclarations for multiple inline symbols. (@​dvandersluis)

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.69.1 (2024-12-03)

Bug fixes

  • #13502: Fix an incorrect autocorrect for Style/DigChain when using safe navigation method chain with dig method. ([@​koic][])
  • #13505: Fix an error for Style/ParallelAssignment when using the anonymous splat operator. ([@​earlopain][])
  • #13184: Fix some false positives in Lint/UnreachableCode. ([@​isuckatcs][])
  • #13494: Fix false positives for Style/HashExcept cop when using reject/!include?, reject/!in? or select/!exclude? combinations. ([@​lovro-bikic][])
  • #13522: Fix Lint/UnescapedBracketInRegexp cop failure with invalid regular expression. ([@​viralpraxis][])
  • #13523: Fix Style::AccessModifierDeclarations cop failure in case of if node without else. ([@​viralpraxis][])
  • #13524: Fix Style/RedundantArgument cop failure while inspecting string literal with invalid encoding. ([@​viralpraxis][])
  • #13528: Fix Style/RedundantParentheses cop failure in case of splatted case node without condition. ([@​viralpraxis][])
  • #13521: Fix Style/RedundantSelf cop failure with kwnilarg argument node. ([@​viralpraxis][])
  • #13526: Fix Style/StringConcatenation cop failure when there are mixed implicit and explicit concatenations. ([@​viralpraxis][])
  • #13511: Fix false positive in Lint/UnescapedBracketInRegexp when using regexp_parser 2.9.2 and earlier. ([@​dvandersluis][])
  • #13096: Update Style/BlockDelimiters to not change braces when they are required for syntax. ([@​dvandersluis][])
  • #13512: Update Style/LambdaCall to be aware of safe navigation. ([@​dvandersluis][])

1.69.0 (2024-11-26)

New features

Bug fixes

  • #13455: Fix a false positive for Layout/EmptyLineAfterGuardClause when using a guard clause outside oneliner block. ([@​koic][])
  • #13412: Fix a false positive for Style/RedundantLineContinuation when there is a line continuation at the end of Ruby code followed by __END__ data. ([@​koic][])
  • #13476: Allow to write generics type of RBS::Inline annotation after subclass definition in Style/CommentedKeyword. ([@​dak2][])
  • #13441: Fix an incorrect autocorrect for Style/IfWithSemicolon when using return with value in if with a semicolon is used. ([@​koic][])
  • #13448: Fix an incorrect autocorrect for Style/IfWithSemicolon when the then body contains an arithmetic operator method call with an argument. ([@​koic][])
  • #13199: Make Style/RedundantCondition skip autocorrection when a branch has a comment. ([@​koic][])
  • #13411: Fix Style/BitwisePredicate when having regular method. ([@​d4be4st][])
  • #13432: Fix false positive for Lint/FloatComparison against nil. ([@​lovro-bikic][])
  • #13461: Fix false positives for Lint/InterpolationCheck when using invalid syntax in interpolation. ([@​koic][])
  • #13402: Fix a false positive for Lint/SafeNavigationConsistency when using unsafe navigation with both && and ||. ([@​koic][])
  • #13434: Fix a false positive for Naming/MemoizedInstanceVariableName for assignment methods`. ([@​earlopain][])
  • #13415: Fix false positives for Naming/MemoizedInstanceVariableName when using initialize_clone, initialize_copy, or initialize_dup. ([@​koic][])
  • #13421: Fix false positives for Style/SafeNavigation when using a method chain that exceeds the MaxChainLength value and includes safe navigation operator. ([@​koic][])
  • #13433: Fix autocorrection for Style/AccessModifierDeclarations for multiple inline symbols. ([@​dvandersluis][])
  • #13430: Fix EmptyLinesAroundMethodBody for methods with arguments spanning multiple lines. ([@​aduth][])
  • #13438: Fix incorrect correction in Lint/Void if an operator is called in a void context using a dot. ([@​dvandersluis][])
  • #13419: Fix Lint/DeprecatedOpenSSLConstant false positive when the argument is a safe navigation method call. ([@​dvandersluis][])
  • #13404: Fix Style/AccessModifierDeclarations to register (as positive or negative, depending on AllowModifiersOnSymbols value) access modifiers with multiple symbols. ([@​dvandersluis][])
  • #13436: Fix incorrect offense and autocorrect for Lint/RedundantSplatExpansion when percent literal array is used in a safe navigation method call. ([@​lovro-bikic][])

... (truncated)

Commits
  • 3d95b38 Cut 1.69.1
  • c60ffa5 Update Changelog
  • 4f2ac18 Lint/BinaryOperatorWithIdenticalOperands: Remove MATH_OPERATORS as they will ...
  • ea4aa48 Merge pull request #13529 from dvandersluis/generator-internal-affairs
  • 12e1ea2 Update rake new_cop to handle InternalAffairs cops
  • 84f3d43 Specify maximum_target_ruby_version for a handful of cops, document it
  • ef8009c Merge pull request #13531 from rubocop/dependabot/github_actions/karancode/ya...
  • 7715ed7 Bump karancode/yamllint-github-action from 2.1.1 to 3.0.0
  • cc43be0 Merge pull request #13528 from viralpraxis/fix-style-redundant-parentheses-co...
  • bd8b674 Fix Style/RedundantParentheses cop failure in case of splatted case node ...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by Sourcery

Bump RuboCop from version 1.66.1 to 1.69.1, introducing new cops and fixing multiple bugs in existing cops.

New Features:

  • Introduce new RuboCop cops: Lint/HashNewWithKeywordArgumentsAsDefault, Lint/NumericOperationWithConstantResult, Style/DigChain, Style/FileNull, Style/FileTouch, and Lint/UselessDefined.

Bug Fixes:

  • Fix incorrect autocorrects and false positives in various RuboCop cops, including Style/DigChain, Style/ParallelAssignment, Lint/UnreachableCode, Style/HashExcept, Lint/UnescapedBracketInRegexp, and others.

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.66.1 to 1.69.1.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.66.1...v1.69.1)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added bundler Ruby gems dependencies External dependencies labels Dec 3, 2024
Copy link

sourcery-ai bot commented Dec 3, 2024

Reviewer's Guide by Sourcery

This PR updates the RuboCop development dependency from version 1.66.1 to 1.69.1. The update includes several new features and bug fixes across two releases (1.69.0 and 1.69.1), with a focus on improving code analysis capabilities and fixing various edge cases in existing cops.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added new linting capabilities with six new cops
  • Added Lint/HashNewWithKeywordArgumentsAsDefault cop
  • Added Lint/NumericOperationWithConstantResult cop
  • Added Style/DigChain cop
  • Added Style/FileNull cop
  • Added Style/FileTouch cop
  • Added Lint/UselessDefined cop
Gemfile.lock
Fixed multiple bug fixes and false positives in existing cops
  • Fixed incorrect autocorrect for Style/DigChain with safe navigation
  • Fixed Style/ParallelAssignment with anonymous splat operator
  • Fixed false positives in Lint/UnreachableCode
  • Fixed Style/HashExcept cop with various method combinations
  • Fixed multiple cop failures with edge cases and invalid syntax
Gemfile.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 12, 2024

Superseded by #86.

@dependabot dependabot bot closed this Dec 12, 2024
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-1.69.1 branch December 12, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bundler Ruby gems dependencies External dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants