[GEM] (deps-dev): Bump rubocop from 1.66.1 to 1.69.0 #82

dependabot · 2024-11-26T18:50:34Z

Bumps rubocop from 1.66.1 to 1.69.0.

Release notes

RuboCop 1.69

New features

#13439: Add new Lint/HashNewWithKeywordArgumentsAsDefault cop. (@koic)

#11191: Add new Lint/BinaryOperatorWithIdenticalOperands cop. ([@zopolis4][])

#13486: Add new Style/DigChain cop. ([@dvandersluis][])

#13490: Add new Style/FileNull cop. ([@dvandersluis][])

#13484: Add new Style/FileTouch cop. ([@lovro-bikic][])

#13437: Add a new cop Lint/UselessDefined to detect cases such as defined?('Foo') when defined?(Foo) was intended. ([@earlopain][])

Bug fixes

#13455: Fix a false positive for Layout/EmptyLineAfterGuardClause when using a guard clause outside oneliner block. (@koic)

#13412: Fix a false positive for Style/RedundantLineContinuation when there is a line continuation at the end of Ruby code followed by __END__ data. (@koic)

#13476: Allow to write generics type of RBS::Inline annotation after subclass definition in Style/CommentedKeyword. ([@dak2][])

#13441: Fix an incorrect autocorrect for Style/IfWithSemicolon when using return with value in if with a semicolon is used. (@koic)

#13448: Fix an incorrect autocorrect for Style/IfWithSemicolon when the then body contains an arithmetic operator method call with an argument. (@koic)

#13199: Make Style/RedundantCondition skip autocorrection when a branch has a comment. (@koic)

#13411: Fix Style/BitwisePredicate when having regular method. ([@d4be4st][])

#13432: Fix false positive for Lint/FloatComparison against nil. ([@lovro-bikic][])

#13461: Fix false positives for Lint/InterpolationCheck when using invalid syntax in interpolation. (@koic)

#13402: Fix a false positive for Lint/SafeNavigationConsistency when using unsafe navigation with both && and ||. (@koic)

#13434: Fix a false positive for Naming/MemoizedInstanceVariableName for assignment methods`. ([@earlopain][])

#13415: Fix false positives for Naming/MemoizedInstanceVariableName when using initialize_clone, initialize_copy, or initialize_dup. (@koic)

#13421: Fix false positives for Style/SafeNavigation when using a method chain that exceeds the MaxChainLength value and includes safe navigation operator. (@koic)

#13433: Fix autocorrection for Style/AccessModifierDeclarations for multiple inline symbols. ([@dvandersluis][])

#13430: Fix EmptyLinesAroundMethodBody for methods with arguments spanning multiple lines. ([@aduth][])

#13438: Fix incorrect correction in Lint/Void if an operator is called in a void context using a dot. ([@dvandersluis][])

#13419: Fix Lint/DeprecatedOpenSSLConstant false positive when the argument is a safe navigation method call. ([@dvandersluis][])

#13404: Fix Style/AccessModifierDeclarations to register (as positive or negative, depending on AllowModifiersOnSymbols value) access modifiers with multiple symbols. ([@dvandersluis][])

#13436: Fix incorrect offense and autocorrect for Lint/RedundantSplatExpansion when percent literal array is used in a safe navigation method call. ([@lovro-bikic][])

#13442: Fix an incorrect autocorrect for Style/NestedTernaryOperator when ternary operators are nested and the inner condition is parenthesized. (@koic)

#13444: Fix an incorrect autocorrect for Style/OneLineConditional when the else branch of a ternary operator has multiple expressions. (@koic)

#13483: Fix an incorrect autocorrect for Style/RedundantRegexpArgument when using escaped double quote character. (@koic)

#13497: Fix infinite loop error for Style/IfWithSemicolon when using nested if/;/end in if body. (@koic)

#13477: Update Layout/LeadingCommentSpace to accept multiline shebangs at the top of the file. ([@dvandersluis][])

#13453: Update Style/AccessModifierDeclarations to handle attr_* methods with multiple parameters. ([@dvandersluis][])

#12597: Update Style/SingleLineDoEndBlock to not register an offense if it will introduce a conflicting Layout/RedundantLineBreak offense. ([@dvandersluis][])

Changes

#11680: Add autocorrection for strings to Layout/LineLength when SplitStrings is set to true. ([@dvandersluis][])

#13470: Make Style/ArrayIntersect aware of none?. ([@earlopain][])

#13481: Support unicode-display_width v3. ([@gemmaro][])

#13473: Update Lint/ItWithoutArgumentsInBlock to not register offenses in Ruby 3.4. ([@dvandersluis][])

#13420: Update Lint/RedundantSafeNavigation to register an offense when the receiver is self. ([@dvandersluis][])

#11393: Update Lint/UnusedMethodArgument to allow the class names for IgnoreNotImplementedMethods to be configured. ([@dvandersluis][])

#13058: Update Style/AccessModifierDeclarations to accept modifier with splatted method call. ([@dvandersluis][])

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.69.0 (2024-11-26)

New features

#13439: Add new Lint/HashNewWithKeywordArgumentsAsDefault cop. ([@koic][])

#11191: Add new Lint/BinaryOperatorWithIdenticalOperands cop. ([@zopolis4][])

#13486: Add new Style/DigChain cop. ([@dvandersluis][])

#13490: Add new Style/FileNull cop. ([@dvandersluis][])

#13484: Add new Style/FileTouch cop. ([@lovro-bikic][])

#13437: Add a new cop Lint/UselessDefined to detect cases such as defined?('Foo') when defined?(Foo) was intended. ([@earlopain][])

Bug fixes

#13455: Fix a false positive for Layout/EmptyLineAfterGuardClause when using a guard clause outside oneliner block. ([@koic][])

#13412: Fix a false positive for Style/RedundantLineContinuation when there is a line continuation at the end of Ruby code followed by __END__ data. ([@koic][])

#13476: Allow to write generics type of RBS::Inline annotation after subclass definition in Style/CommentedKeyword. ([@dak2][])

#13441: Fix an incorrect autocorrect for Style/IfWithSemicolon when using return with value in if with a semicolon is used. ([@koic][])

#13448: Fix an incorrect autocorrect for Style/IfWithSemicolon when the then body contains an arithmetic operator method call with an argument. ([@koic][])

#13199: Make Style/RedundantCondition skip autocorrection when a branch has a comment. ([@koic][])

#13411: Fix Style/BitwisePredicate when having regular method. ([@d4be4st][])

#13432: Fix false positive for Lint/FloatComparison against nil. ([@lovro-bikic][])

#13461: Fix false positives for Lint/InterpolationCheck when using invalid syntax in interpolation. ([@koic][])

#13402: Fix a false positive for Lint/SafeNavigationConsistency when using unsafe navigation with both && and ||. ([@koic][])

#13434: Fix a false positive for Naming/MemoizedInstanceVariableName for assignment methods`. ([@earlopain][])

#13415: Fix false positives for Naming/MemoizedInstanceVariableName when using initialize_clone, initialize_copy, or initialize_dup. ([@koic][])

#13421: Fix false positives for Style/SafeNavigation when using a method chain that exceeds the MaxChainLength value and includes safe navigation operator. ([@koic][])

#13433: Fix autocorrection for Style/AccessModifierDeclarations for multiple inline symbols. ([@dvandersluis][])

#13430: Fix EmptyLinesAroundMethodBody for methods with arguments spanning multiple lines. ([@aduth][])

#13438: Fix incorrect correction in Lint/Void if an operator is called in a void context using a dot. ([@dvandersluis][])

#13419: Fix Lint/DeprecatedOpenSSLConstant false positive when the argument is a safe navigation method call. ([@dvandersluis][])

#13404: Fix Style/AccessModifierDeclarations to register (as positive or negative, depending on AllowModifiersOnSymbols value) access modifiers with multiple symbols. ([@dvandersluis][])

#13436: Fix incorrect offense and autocorrect for Lint/RedundantSplatExpansion when percent literal array is used in a safe navigation method call. ([@lovro-bikic][])

#13442: Fix an incorrect autocorrect for Style/NestedTernaryOperator when ternary operators are nested and the inner condition is parenthesized. ([@koic][])

#13444: Fix an incorrect autocorrect for Style/OneLineConditional when the else branch of a ternary operator has multiple expressions. ([@koic][])

#13483: Fix an incorrect autocorrect for Style/RedundantRegexpArgument when using escaped double quote character. ([@koic][])

#13497: Fix infinite loop error for Style/IfWithSemicolon when using nested if/;/end in if body. ([@koic][])

#13477: Update Layout/LeadingCommentSpace to accept multiline shebangs at the top of the file. ([@dvandersluis][])

#13453: Update Style/AccessModifierDeclarations to handle attr_* methods with multiple parameters. ([@dvandersluis][])

#12597: Update Style/SingleLineDoEndBlock to not register an offense if it will introduce a conflicting Layout/RedundantLineBreak offense. ([@dvandersluis][])

Changes

#11680: Add autocorrection for strings to Layout/LineLength when SplitStrings is set to true. ([@dvandersluis][])

#13470: Make Style/ArrayIntersect aware of none?. ([@earlopain][])

#13481: Support unicode-display_width v3. ([@gemmaro][])

#13473: Update Lint/ItWithoutArgumentsInBlock to not register offenses in Ruby 3.4. ([@dvandersluis][])

#13420: Update Lint/RedundantSafeNavigation to register an offense when the receiver is self. ([@dvandersluis][])

#11393: Update Lint/UnusedMethodArgument to allow the class names for IgnoreNotImplementedMethods to be configured. ([@dvandersluis][])

#13058: Update Style/AccessModifierDeclarations to accept modifier with splatted method call. ([@dvandersluis][])

... (truncated)

Commits

9a49a33 Cut 1.69
96833cd Update Changelog
32c8dd5 Merge pull request #13498 from dvandersluis/useless-include-util
2904985 Remove unnecessary include Util
77f3e6f Create Style/FileTouch cop
8ac8947 Fix infinite loop error for Style/IfWithSemicolon
beb22bc Update Style/SingleArgumentDig to not register offenses on chained dig ca...
c8cdb3d [Fix #13486] Add new Style/DigChain cop
efc3fd8 [Fix #13490] Add new Style/FileNull cop
8717f11 Remove unnecessary include IgnoredNode
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by Sourcery

Build:

Bump rubocop from version 1.66.1 to 1.69.0 in the Gemfile.lock.

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.66.1 to 1.69.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.66.1...v1.69.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

sourcery-ai · 2024-11-26T18:50:41Z

Reviewer's Guide by Sourcery

This PR updates the RuboCop gem from version 1.66.1 to 1.69.0. The update introduces several new linting cops, fixes multiple bugs in existing cops, and includes some behavior changes to improve code analysis capabilities.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Added new linting cops for improved code quality checks	Added Lint/HashNewWithKeywordArgumentsAsDefault to check hash initialization Added Lint/BinaryOperatorWithIdenticalOperands to detect redundant operations Added Lint/UselessDefined to catch incorrect defined? usage Added Style/DigChain for dig method chain optimization Added Style/FileNull for file existence checks Added Style/FileTouch for file touch operations	`Gemfile.lock`
Fixed various false positives and incorrect autocorrections	Fixed false positives in Layout/EmptyLineAfterGuardClause Fixed incorrect autocorrect for Style/IfWithSemicolon Fixed false positives in Lint/FloatComparison Fixed issues with Style/AccessModifierDeclarations Fixed autocorrection in Style/NestedTernaryOperator	`Gemfile.lock`
Enhanced existing cop behaviors and configurations	Added string autocorrection to Layout/LineLength when SplitStrings is true Updated Style/ArrayIntersect to handle none? method Added support for unicode-display_width v3 Updated Lint/UnusedMethodArgument to allow configurable class names Modified Style/AccessModifierDeclarations to handle splatted method calls	`Gemfile.lock`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time. You can also use
this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!

dependabot · 2024-12-03T18:35:02Z

Superseded by #84.

dependabot bot added bundler Ruby gems dependencies External dependencies labels Nov 26, 2024

dependabot bot mentioned this pull request Nov 26, 2024

[GEM] (deps-dev): Bump rubocop from 1.66.1 to 1.68.0 #70

Closed

sourcery-ai bot reviewed Nov 26, 2024

View reviewed changes

dependabot bot closed this Dec 3, 2024

dependabot bot deleted the dependabot/bundler/rubocop-1.69.0 branch December 3, 2024 18:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GEM] (deps-dev): Bump rubocop from 1.66.1 to 1.69.0 #82

[GEM] (deps-dev): Bump rubocop from 1.66.1 to 1.69.0 #82

dependabot bot commented on behalf of github Nov 26, 2024 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Nov 26, 2024 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

sourcery-ai bot left a comment

dependabot bot commented on behalf of github Dec 3, 2024

[GEM] (deps-dev): Bump rubocop from 1.66.1 to 1.69.0 #82

[GEM] (deps-dev): Bump rubocop from 1.66.1 to 1.69.0 #82

Conversation

dependabot bot commented on behalf of github Nov 26, 2024 • edited by sourcery-ai bot Loading

RuboCop 1.69

New features

Bug fixes

Changes

1.69.0 (2024-11-26)

New features

Bug fixes

Changes

Summary by Sourcery

sourcery-ai bot commented Nov 26, 2024 • edited Loading

Reviewer's Guide by Sourcery

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

sourcery-ai bot left a comment

Choose a reason for hiding this comment

dependabot bot commented on behalf of github Dec 3, 2024

dependabot bot commented on behalf of github Nov 26, 2024 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Nov 26, 2024 •

edited

Loading