Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ignoring of invalid CRCs in archive header #82

Closed
abbeycode opened this issue Sep 14, 2019 · 0 comments
Closed

Allow ignoring of invalid CRCs in archive header #82

abbeycode opened this issue Sep 14, 2019 · 0 comments
Assignees
@abbeycode
Labels
enhancement
Milestone
2.10

Comments

@abbeycode
Copy link
Owner

Sometimes archives get written with bad CRC values in their headers, and it's common for RAR readers to give users the option to ignore these invalid CRCs, so UnrarKit should give the option to do so. This may also resolve #81.
@abbeycode abbeycode self-assigned this Sep 14, 2019
@abbeycode abbeycode added this to the 2.10 milestone Sep 14, 2019
abbeycode added a commit that referenced this issue Sep 23, 2019
@abbeycode
Implemented a way for users to opt into ignoring mismatched CRCs in a…
446aa02 
…n archive header (Issue #82), and consistently replaced all references to 'self' inside blocks with 'welf'
@abbeycode abbeycode mentioned this issue Sep 23, 2019
Merged
abbeycode added a commit that referenced this issue Sep 26, 2019
@abbeycode
Made ignoreCRCMismatches property public, so it can be set by an API …
b68a02d 
…consumer, for purposes such as implementing a user preference to always ignore mismatches for a given file (or all files, etc.) (Issue #82)
abbeycode added a commit that referenced this issue Sep 26, 2019
@abbeycode
Made ignoreCRCMismatches property public, so it can be set by an API …
edeabea 
…consumer, for purposes such as implementing a user preference to always ignore mismatches for a given file (or all files, etc.) (Issue #82)
abbeycode added a commit that referenced this issue Sep 26, 2019
@abbeycode
Made ignoreCRCMismatches property public, so it can be set by an API …
4a3d406 
…consumer, for purposes such as implementing a user preference to always ignore mismatches for a given file (or all files, etc.) (Issue #82)
abbeycode added a commit that referenced this issue Sep 26, 2019
@abbeycode
Merge pull request #84 from abbeycode/issue82-ignore-bad-CRCs
af5acfd 
Allow users to ignore bad CRCs (Issue #82)
abbeycode added a commit that referenced this issue Oct 24, 2019
@abbeycode
Fixed bug introduced by allowing operations to continue with bad CRCs…
7397b74 
…, and added a new test (Issue #82)
xiaogdgenuine pushed a commit to xiaogdgenuine/UnrarKit that referenced this issue Nov 5, 2020
@abbeycode @xiaogdgenuine
Implemented a way for users to opt into ignoring mismatched CRCs in a…
79a32cc 
…n archive header (Issue abbeycode#82), and consistently replaced all references to 'self' inside blocks with 'welf'
xiaogdgenuine pushed a commit to xiaogdgenuine/UnrarKit that referenced this issue Nov 5, 2020
@abbeycode @xiaogdgenuine
Made ignoreCRCMismatches property public, so it can be set by an API …
53eff41 
…consumer, for purposes such as implementing a user preference to always ignore mismatches for a given file (or all files, etc.) (Issue abbeycode#82)
xiaogdgenuine pushed a commit to xiaogdgenuine/UnrarKit that referenced this issue Nov 5, 2020
@abbeycode @xiaogdgenuine
Fixed bug introduced by allowing operations to continue with bad CRCs…
00c43dd 
…, and added a new test (Issue abbeycode#82)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abbeycode abbeycode

Labels
enhancement
Projects
None yet
Milestone
2.10
Development

No branches or pull requests
1 participant
@abbeycode