Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate ros_control plugin #7

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

mintar
Copy link
Contributor

@mintar mintar commented Jul 12, 2018

There was a duplicate ros_control plugin, which made it impossible to
control the base in kinetic.

Steps to reproduce:

roslaunch youbot_gazebo_robot youbot.launch
gzclient
rosrun rqt_robot_steering rqt_robot_steering

Now try moving the robot around using the rqt_robot_steering GUI.
Without this fix, it doesn't work.

This fixes a bug introduced in afe9ee9 (#4).

There was a duplicate ros_control plugin, which made it impossible to
control the base in kinetic.

Steps to reproduce:

```
roslaunch youbot_gazebo_robot youbot.launch
gzclient
rosrun rqt_robot_steering rqt_robot_steering
```

Now try moving the robot around using the rqt_robot_steering GUI.
Without this fix, it doesn't work.

This fixes a bug introduced in afe9ee9 (a2s-institute#4).
@moriarty
Copy link
Contributor

moriarty commented Mar 6, 2019

@sthoduka also, can you update the default branch?

I didn't run into this problem because I cloned the repo which gave me the indigo-devel branch and then went and fixed the warnings which #4 introduced, and then was going to submit a PR.

#6 and #7 are duplicates.

@moriarty
Copy link
Contributor

moriarty commented Mar 6, 2019

or alternatively @alex-mitrevski.

I don't know who's managing the @b-it-bots vs @mas-group organizations

@sthoduka sthoduka merged commit 4cf2efb into a2s-institute:kinetic-devel Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants