Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Plugin URL: yourls-conditional-urlads #132

Closed
wants to merge 3 commits into from
Closed

Update Plugin URL: yourls-conditional-urlads #132

wants to merge 3 commits into from

Conversation

8MiYile
Copy link
Contributor

@8MiYile 8MiYile commented Dec 5, 2022

yourls-conditional-urlads

yourls-conditional-urlads
@8MiYile 8MiYile changed the title Update Plugin URL Update Plugin URL: yourls-conditional-urlads Dec 5, 2022
@ozh
Copy link
Member

ozh commented Dec 5, 2022

Hi, as I understand it, this is not a new URL for a plugin. Your plugin is an updated fork, hence a new plugin. Hence, the 2 should be mentioned.

@8MiYile
Copy link
Contributor Author

8MiYile commented Dec 6, 2022

Hi, as I understand it, this is not a new URL for a plugin. Your plugin is an updated fork, hence a new plugin. Hence, the 2 should be mentioned.

But the original author no longer cares about this plugin, I take over the updating and patching of this plugin and also allow adding multiple languages in terms of README

@ozh
Copy link
Member

ozh commented Dec 6, 2022

Yes. An updated fork.

@8MiYile
Copy link
Contributor Author

8MiYile commented Dec 6, 2022

So it can be merged?

@LeoColomb
Copy link
Member

As mentioned by @ozh, while adding yours is very welcome, it does not seem relevant to remove the other one, actively maintained by @HeroCC, the author.
Could you update your pull request to add it as a separate link?

@8MiYile
Copy link
Contributor Author

8MiYile commented Dec 8, 2022

Okay, can you check out the changes I made?

@ozh
Copy link
Member

ozh commented Dec 11, 2022

This is another plugin. So it goes on another line.

@8MiYile
Copy link
Contributor Author

8MiYile commented Dec 12, 2022

The plugins are the same, but I'm a radical and he's a conservative, so mine and his only distinguish between development and stable versions.

@ozh ozh closed this Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants