Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed redirection after advertisement site #4

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

JackBailey
Copy link
Contributor

It would redirect to the advertisement site fine but after it would redirect to the system home, this worked for me and should work perfectly for everyone else.
You may need to change line 54 (starting return '//' . $_SERVER['SERVER_NAME'] ) as the comment says if yourls is not installed in your base domain

It would redirect to the advertisement site fine but after it would redirect to the system home, this worked for me and should work perfectly for everyone else.
You may need to change line 54 (starting return '//' . $_SERVER['SERVER_NAME'] ) as the comment says if yourls is not installed in your base domain
@JackBailey
Copy link
Contributor Author

There may be a few inefficiencies with the code as I haven't written in php or have much experience with making a yourls plugin but it works and I've commented what the lines I added do so you're welcome to fix them

@8MiYile
Copy link

8MiYile commented Dec 5, 2022

Hi brother, my repository references your updates and supports git updates
Thanks
https://github.com/8Mi-Tech/yourls-conditional-urlads

@JackBailey
Copy link
Contributor Author

Hi brother, my repository references your updates and supports git updates
Thanks
https://github.com/8Mi-Tech/yourls-conditional-urlads

Looks great, thanks. Might be worth submitting a PR to the plugin list for yourls if you haven't already

@8MiYile
Copy link

8MiYile commented Dec 5, 2022

Hi brother, my repository references your updates and supports git updates
Thanks
https://github.com/8Mi-Tech/yourls-conditional-urlads

Looks great, thanks. Might be worth submitting a PR to the plugin list for yourls if you haven't already

YOURLS/awesome#132

@8MiYile
Copy link

8MiYile commented Dec 5, 2022

@JackBailey you can check out my update log
8Mi-Tech#1

@HeroCC
Copy link
Owner

HeroCC commented Dec 5, 2022

sorry I didn't see this until now, merging -- thanks for the contribution!

@HeroCC HeroCC merged commit 0cbcfed into HeroCC:master Dec 5, 2022
@HeroCC
Copy link
Owner

HeroCC commented Dec 5, 2022

Fixes #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants