Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spng encoder #3374

Closed
totaam opened this issue Dec 1, 2021 · 2 comments
Closed

spng encoder #3374

totaam opened this issue Dec 1, 2021 · 2 comments
Labels
encoding enhancement New feature or request

Comments

@totaam
Copy link
Collaborator

totaam commented Dec 1, 2021

Same as #3373 was for decoding.

Fedora 35 ships version 0.7.0 in the updates channel.
@totaam totaam added enhancement New feature or request encoding labels Dec 1, 2021
totaam added a commit that referenced this issue Dec 2, 2021
@totaam
#3374 add spng encoder
b8d91b7
@totaam totaam mentioned this issue Dec 4, 2021
Closed
totaam added a commit that referenced this issue Dec 4, 2021
@totaam
#3374 try to tune for better performance
76ae51d
totaam added a commit that referenced this issue Dec 4, 2021
@totaam
#3374 add simple benchmark tool
4fd50ba
@totaam
Copy link
Collaborator Author

totaam commented Dec 4, 2021

Apart from some bugs that I still need to fix (random images failing to compress with a size error), the key problem is the performance: randy408/libspng#191
4 MPixels/s is not enough, especially when pillow does ~12 MPixels/s.

totaam added a commit that referenced this issue Dec 4, 2021
@totaam
#3374 tune for best performance
66ea1f2
totaam added a commit that referenced this issue Dec 4, 2021
@totaam
#3374 fix RGB encode: always restride
715efbc
@totaam
Copy link
Collaborator Author

totaam commented Dec 5, 2021

Performance is now much better than libpng via pillow.

One issue that remains is that the restriding / scaling / pixel format conversion steps should be combined: #3357.

@totaam totaam closed this as completed Dec 5, 2021
totaam added a commit that referenced this issue Dec 6, 2021
@totaam
#3374 add 'save-to-file' support
500fb1d
totaam added a commit that referenced this issue Nov 26, 2022
@totaam
#3374 spng uses unpremultiplied alpha
644e061
totaam added a commit that referenced this issue Nov 26, 2022
@totaam
#3374 spng uses unpremultiplied alpha
5c694b0
@totaam totaam mentioned this issue Mar 11, 2023
Open
totaam added a commit that referenced this issue Mar 14, 2023
@totaam
#3373 / #3374 add spng for bookworm, sid and lunar
74ada32
totaam added a commit that referenced this issue Mar 18, 2023
@totaam
#3373 #3374 also add spng runtime dependency
f0e8359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
encoding enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@totaam