Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

downscale and convert in a single step #3357

Open
totaam opened this issue Nov 20, 2021 · 3 comments
Open

downscale and convert in a single step #3357

totaam opened this issue Nov 20, 2021 · 3 comments
Labels
encoding enhancement New feature or request

Comments

@totaam
Copy link
Collaborator

totaam commented Nov 20, 2021 •
edited
Loading

See #2052 and b764753

We should combine the scaling, re-striding and format conversion.
Also support swscale since Debian still does not package libyuv.

After potentially downscaling the image (if requested by the client):

  • webp may reformat it to BGRA or BGRX
  • jpeg should reformat it to RGB to save space (and leave it alone if not downscaling, or if using libyuv for scaling)
  • nvjpeg must convert to RGB or BGR (could also support GBRP)

See also #3370
This was referenced Nov 20, 2021
Closed
Closed
totaam added a commit that referenced this issue Nov 29, 2021
@totaam
#2984 / #3357 csc and downscale using a CUDA kernel
749598a 
accept BGRX as input and convert it to RGB using a cuda kernel,
downscaling it if necessary
This was referenced Dec 4, 2021
Closed
Closed
@totaam
Copy link
Collaborator Author

totaam commented Dec 7, 2021 •
edited
Loading

See also: #2773, #839, #1597, #3370

spng also needs to call unpremultiply_argb: 644e061

@totaam totaam added enhancement New feature or request encoding labels Dec 3, 2022
@totaam
Copy link
Collaborator Author

totaam commented Feb 21, 2023 •
edited
Loading

Related, but nvidia only: https://github.com/NVIDIA/DLSS - https://github.com/NVIDIAGameWorks/NVIDIAImageScaling, https://github.com/NVIDIA/nvcomp

@totaam
Copy link
Collaborator Author

totaam commented Aug 28, 2023

Update: Debian is now packaging libyuv and swscale has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
encoding enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@totaam