Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init global variables once at dlopen #124

Merged
merged 2 commits into from
Jan 29, 2022

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Jan 26, 2022

Move global variables initialization out of binding initialization. The binding initialization function may be called several times when worker_threads is supported.

@legendecas legendecas force-pushed the logger branch 2 times, most recently from 3486912 to 1b8efc0 Compare January 26, 2022 07:27
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #124 (756af9a) into master (5278a3a) will not change coverage.
The diff coverage is n/a.

❗ Current head 756af9a differs from pull request most recent head c468f62. Consider uploading reports for the commit c468f62 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master      #124   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          287       287           
=========================================
  Hits           287       287           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5278a3a...c468f62. Read the comment docs.

@legendecas legendecas marked this pull request as ready for review January 26, 2022 10:34
@legendecas legendecas requested a review from hyj1991 January 26, 2022 13:02
Copy link
Member

@hyj1991 hyj1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hyj1991 hyj1991 merged commit 6848552 into X-Profiler:master Jan 29, 2022
@legendecas legendecas deleted the logger branch February 7, 2022 03:45
@hyj1991 hyj1991 mentioned this pull request Feb 10, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants