fix: va_list shouldn't be converted to nullptr

PR-URL: #125 Reviewed-BY: hyj1991 <[email protected]>
X-Profiler · Jan 27, 2022 · 5278a3a · 5278a3a
1 parent 077f6e3
commit 5278a3a
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/logger.cc b/src/logger.cc
@@ -28,10 +28,10 @@ using v8::String;
   type##_stream.close();                       \
   uv_mutex_unlock(&logger_mutex);
 
-#define LOG_WITH_LEVEL(level)                    \
-  va_list args;                                  \
-  va_start(args, format);                        \
-  Log(LOG_LEVEL::level, log_type, format, args); \
+#define LOG_WITH_LEVEL(level)                     \
+  va_list args;                                   \
+  va_start(args, format);                         \
+  Log(LOG_LEVEL::level, log_type, format, &args); \
   va_end(args);
 
 #define JS_LOG_WITH_LEVEL(level)                                               \
@@ -90,7 +90,7 @@ static void WriteToFile(const LOG_LEVEL output_level, char *log) {
 }
 
 static void Log(const LOG_LEVEL output_level, const char *type,
-                const char *format, va_list arglist = nullptr) {
+                const char *format, va_list *arglist = nullptr) {
   LOG_LEVEL level = GetLogLevel();
   if (level < output_level) {
     return;
@@ -147,7 +147,7 @@ static void Log(const LOG_LEVEL output_level, const char *type,
   // compose log
   char tmp_log[kMaxMessageLength];
   if (arglist != nullptr)
-    vsnprintf(tmp_log, sizeof(tmp_log), tmp_format, arglist);
+    vsnprintf(tmp_log, sizeof(tmp_log), tmp_format, *arglist);
   else
     snprintf(tmp_log, sizeof(tmp_log), "%s", tmp_format);