deps: update dependencies

- deps: update dependencies - @mapbox/node-pre-gyp from v1.0.6 -> 1.0.8 - autod from 3.1.1 -> 3.1.2 - urllib from 2.37.4 -> 2.38.0 - chore: add gcc flag -Wconversion & -Wno-sign-conversion to detect precision loss by implicit conversions PR-URL: #116 Reviewed-BY: hyj1991 <[email protected]>
X-Profiler · Dec 18, 2021 · ca07a81 · ca07a81
1 parent 170052b
commit ca07a81
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 10 deletions.
diff --git a/binding.gyp b/binding.gyp
@@ -59,7 +59,9 @@
                     'xcode_settings': {
                         'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
                         'OTHER_CFLAGS': [
-                            "-std=c++14"
+                            "-std=c++14",
+                            "-Wconversion",
+                            "-Wno-sign-conversion",
                         ]
                     },
                     "defines": [

diff --git a/package.json b/package.json
@@ -55,15 +55,15 @@
   },
   "homepage": "https://github.com/X-Profiler/xprofiler#readme",
   "dependencies": {
-    "@mapbox/node-pre-gyp": "^1.0.6",
+    "@mapbox/node-pre-gyp": "^1.0.8",
     "moment": "^2.29.1",
     "nan": "^2.15.0",
     "uuid": "^8.3.2",
     "yargs": "^15.4.1"
   },
   "devDependencies": {
     "@istanbuljs/schema": "^0.1.3",
-    "autod": "^3.1.1",
+    "autod": "^3.1.2",
     "clang-format": "^1.6.0",
     "codecov": "^3.8.3",
     "eslint": "^6.8.0",
@@ -73,7 +73,7 @@
     "mocha": "^7.2.0",
     "nyc": "^15.1.0",
     "tunnel-agent": "^0.6.0",
-    "urllib": "^2.37.4"
+    "urllib": "^2.38.0"
   },
   "xctlIpcPath": {
     "unix": "xprofiler-ctl-uds-path.sock",

diff --git a/src/library/utils.cc b/src/library/utils.cc
@@ -22,7 +22,7 @@ string FmtMessage(const char *format, ...) {
 }
 
 string RandNum() {
-  srand(uv_hrtime() + rand());
+  srand(static_cast<int>(uv_hrtime() + rand()));
   return std::to_string(rand() % 900000 + 100000);
 }
 

diff --git a/src/logbypass/gc.cc b/src/logbypass/gc.cc
@@ -18,7 +18,7 @@ unsigned int TotalGcTimes() {
   return gc_statistics->total_gc_times;
 }
 
-unsigned int TotalGcDuration() {
+unsigned long TotalGcDuration() {
   if (gc_statistics == nullptr) {
     return 0;
   }
@@ -44,7 +44,7 @@ NAN_GC_CALLBACK(GCEpilogueCallback) {
   }
 
   gc_statistics->total_gc_times++;
-  unsigned int duration = (now - start) / 10e5;  // cost, ms
+  unsigned int duration = static_cast<int>((now - start) / 10e5);  // cost, ms
 
   // check duration is legal
   if (duration >= 5 * 60 * 1000) {

diff --git a/src/logbypass/gc.h b/src/logbypass/gc.h
@@ -38,7 +38,7 @@ typedef struct GcStatistics {
 int InitGcStatusHooks();
 void WriteGcStatusToLog(bool log_format_alinode);
 unsigned int TotalGcTimes();
-unsigned int TotalGcDuration();
+unsigned long TotalGcDuration();
 }  // namespace xprofiler
 
 #endif
diff --git a/src/platform/unix/ipc.cc b/src/platform/unix/ipc.cc
@@ -115,7 +115,7 @@ void CreateIpcServer(void (*parsecmd)(char *)) {
 
     // read client data
     char data_buffer[CLIENT_BUFFER_SIZE] = {0};
-    int recv_res = recv(new_client_fd, data_buffer, CLIENT_BUFFER_SIZE, 0);
+    ssize_t recv_res = recv(new_client_fd, data_buffer, CLIENT_BUFFER_SIZE, 0);
     if (recv_res == -1) {
       TEARDOWN("recv client data error.")
       continue;
@@ -158,7 +158,7 @@ void CreateIpcClient(char *message) {
   }
 
   // send message
-  int send_res = send(client_fd, message, strlen(message), 0);
+  ssize_t send_res = send(client_fd, message, strlen(message), 0);
   if (send_res == -1) {
     Error("ipc", "send message failed: %s.", message);
     return;