fix: precision loss in (CpuProfileNode*) ptr->GetSampleTimestamp()

PR-URL: #115 Reviewed-BY: hyj1991 <[email protected]>
X-Profiler · Dec 18, 2021 · 170052b · 170052b
1 parent d363f1c
commit 170052b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/src/commands/cpuprofiler/cpu_profile.cc b/src/commands/cpuprofiler/cpu_profile.cc
@@ -38,19 +38,19 @@ void Profile::Serialize(const CpuProfile *node, std::string filename) {
   writer.json_keyvalue("endTime", node->GetEndTime());
 
   // set samples
-  uint32_t count = node->GetSamplesCount();
+  int count = node->GetSamplesCount();
   writer.json_arraystart("samples");
-  for (uint32_t index = 0; index < count; ++index) {
+  for (int index = 0; index < count; ++index) {
     writer.json_element(node->GetSample(index)->GetNodeId());
   }
   writer.json_arrayend();
 
   // set timestamps
   writer.json_arraystart("timeDeltas");
-  for (uint32_t index = 0; index < count; ++index) {
-    uint32_t prev =
+  for (int index = 0; index < count; ++index) {
+    int64_t prev =
         index == 0 ? node->GetStartTime() : node->GetSampleTimestamp(index - 1);
-    uint32_t delta = node->GetSampleTimestamp(index) - prev;
+    int64_t delta = node->GetSampleTimestamp(index) - prev;
     writer.json_element(delta);
   }
   writer.json_arrayend();

diff --git a/src/commands/cpuprofiler/cpu_profile_node.cc b/src/commands/cpuprofiler/cpu_profile_node.cc
@@ -25,15 +25,15 @@ void ProfileNode::SerializeNode(const CpuProfileNode *node,
   writer->json_objectend();
 
   // set children
-  int32_t count = node->GetChildrenCount();
+  int count = node->GetChildrenCount();
   writer->json_arraystart("children");
-  for (int32_t index = 0; index < count; index++) {
+  for (int index = 0; index < count; index++) {
     writer->json_element(node->GetChild(index)->GetNodeId());
   }
   writer->json_arrayend();
   writer->json_end();
 
-  for (int32_t index = 0; index < count; index++) {
+  for (int index = 0; index < count; index++) {
     ProfileNode::SerializeNode(node->GetChild(index), writer);
   }
 }

diff --git a/test/fixtures/command.test.js b/test/fixtures/command.test.js
@@ -56,7 +56,7 @@ const cpuprofile = {
       functionName: /^([$.\w\s()-_]+|)$/,
       scriptId: /^\d+$/,
       bailoutReason: /^([\w\s]+|)$/,
-      url: /^([@.\w()/\\:_-]+|)$/,
+      url: /^([@.\w()/\\:_-\s]+|)$/,
       lineNumber: /^\d+$/,
       columnNumber: /^\d+$/,
     },
@@ -98,7 +98,7 @@ const heapprofile = {
     callFrame: {
       functionName: /^([$.\w\s()-_]+|)$/,
       scriptId: /^\d+$/,
-      url: /^([@.\w()/\\:_-]+|)$/,
+      url: /^([@.\w()/\\:_-\s]+|)$/,
       lineNumber: /^\d+$/,
       columnNumber: /^\d+$/
     },