-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: logs api #203
feat: logs api #203
Conversation
aa95d5a
to
cc598cb
Compare
branch rebased from latest |
Hi @blakeroberts-wk , about unit test, seems like the part that is causing it to fail is
I ran removing |
cb2b173
to
a2084c0
Compare
rebased with latest master |
QA +1 experimental public or private API additions only, CI is sufficient |
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Which problem is this PR solving?
Fixes # (issue)
Short description of the change
experimental_api.dart
as in js, this feature is still in experimental, butexperimental_api.dart
is placed underlib/src/
instead oflib/
which will require defining importpackage:opentelemetry/lib/src/experimental_api.dart
when need it. Let me know if I should place them undersdk.dart
How Has This Been Tested?
Checklist: