Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proto logs #202

Merged
merged 4 commits into from
Jan 14, 2025
Merged

feat: proto logs #202

merged 4 commits into from
Jan 14, 2025

Conversation

yuzurihaaa
Copy link
Contributor

@yuzurihaaa yuzurihaaa commented Jan 9, 2025

Which problem is this PR solving?

To add proto generated dart files. Next PR will be to create API for log.

Short description of the change

Add generated proto files.

How Has This Been Tested?

Please describe the tests that you ran to verify your change. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  1. Ran unit tests

Checklist:

  • Unit tests have been added
  • Documentation has been updated

@yuzurihaaa
Copy link
Contributor Author

I am not sure how do I fill up for the checklist, as I am just generating the files.

This was referenced Jan 10, 2025
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@blakeroberts-wk blakeroberts-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for separating out the PRs. This makes reviewing the changes much easier.

Changes look good! Two nits:

  • Alphabetized file names in the Makefile.
  • I don't think this PR should close the log feature issue, we should wait for the other PRs.

@yuzurihaaa
Copy link
Contributor Author

yuzurihaaa commented Jan 11, 2025

removed mentioning issue.

@blakeroberts-wk
Copy link
Contributor

QA +1 generated files only

@blakeroberts-wk
Copy link
Contributor

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@btr-rmconsole-4 btr-rmconsole-4 bot merged commit 8385961 into Workiva:master Jan 14, 2025
3 checks passed
@yuzurihaaa yuzurihaaa deleted the feat/yr/proto branch January 14, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants