-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: proto logs #202
feat: proto logs #202
Conversation
695d8f3
to
de92be9
Compare
I am not sure how do I fill up for the checklist, as I am just generating the files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for separating out the PRs. This makes reviewing the changes much easier.
Changes look good! Two nits:
- Alphabetized file names in the Makefile.
- I don't think this PR should close the log feature issue, we should wait for the other PRs.
removed mentioning issue. |
QA +1 generated files only |
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Which problem is this PR solving?
To add proto generated dart files. Next PR will be to create API for log.
Short description of the change
Add generated proto files.
How Has This Been Tested?
Please describe the tests that you ran to verify your change. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: