Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Canary: Apply single font sizes as overrides and remove font family definition on headings #279

Merged
merged 4 commits into from
Oct 17, 2022
Merged

Canary: Apply single font sizes as overrides and remove font family definition on headings #279

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6acc021
Apply font sizes as overrides
mikachan Oct 11, 2022
04475cf
Add all font sizes
mikachan Oct 11, 2022
3d222ae
Allow all font sizes to be fluid
mikachan Oct 13, 2022
1a3da61
Remove font family setting on core/heading
mikachan Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions styles/canary.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,19 +52,19 @@
"slug": "small"
},
{
"size": "0.75rem",
"size": "1.125rem",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the only change to the fontSizes compared to theme.json is that they are not fluid, I wonder if this could be simplified 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference with the Canary fontSizes is that they're all the same size.

"slug": "medium"
},
{
"size": "0.75rem",
"size": "1.75rem",
"slug": "large"
},
{
"size": "0.75rem",
"size": "2.25rem",
"slug": "x-large"
},
{
"size": "0.75rem",
"size": "10rem",
"slug": "xx-large"
}
]
Expand All @@ -91,9 +91,9 @@
"fontSize": "var(--wp--preset--font-size--small)"
}
},
"core/heading": {
"core/comments-title":{
"typography": {
"fontFamily": "var(--wp--preset--font-family--ibm-plex-mono)"
"fontSize": "var(--wp--preset--font-size--small)"
}
},
"core/image": {
Expand Down Expand Up @@ -123,6 +123,11 @@
}
}
},
"core/post-excerpt": {
"typography": {
"fontSize": "var(--wp--preset--font-size--small)"
}
},
"core/post-featured-image": {
"border": {
"radius": "100px 0 0 0"
Expand Down Expand Up @@ -162,7 +167,8 @@
"core/site-title": {
"typography": {
"fontWeight": "700",
"textTransform": "lowercase"
"textTransform": "lowercase",
"fontSize": "var(--wp--preset--font-size--small)"
}
}
},
Expand Down Expand Up @@ -210,22 +216,22 @@
},
"h1": {
"typography": {
"fontSize": "var(--wp--preset--font-size--medium)"
"fontSize": "var(--wp--preset--font-size--small)"
}
},
"h2": {
"typography": {
"fontSize": "var(--wp--preset--font-size--medium)"
"fontSize": "var(--wp--preset--font-size--small)"
}
},
"h3": {
"typography": {
"fontSize": "var(--wp--preset--font-size--medium)"
"fontSize": "var(--wp--preset--font-size--small)"
}
},
"h4": {
"typography": {
"fontSize": "var(--wp--preset--font-size--medium)"
"fontSize": "var(--wp--preset--font-size--small)"
}
},
"heading": {
Expand All @@ -240,7 +246,8 @@
}
},
"typography": {
"fontFamily": "var(--wp--preset--font-family--ibm-plex-mono)"
"fontFamily": "var(--wp--preset--font-family--ibm-plex-mono)",
"fontSize": "var(--wp--preset--font-size--small)"
}
}
}