This repository has been archived by the owner on Oct 28, 2022. It is now read-only.
Canary: Apply single font sizes as overrides and remove font family definition on headings #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
reviewed
Oct 13, 2022
| @@ -52,19 +52,20 @@ | |||
| "slug": "small" | |||
| }, | |||
| { | |||
| "size": "0.75rem", | |||
| "size": "1.125rem", | |||
There was a problem hiding this comment.
If the only change to the fontSizes compared to theme.json is that they are not fluid, I wonder if this could be simplified 🤔
There was a problem hiding this comment.
The difference with the Canary fontSizes is that they're all the same size.
mikachan
changed the title
|
I'm going to bring this in as I believe it addresses the issues from #278, but please open any further related issues if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way the single font size preset is applied in Canary, as it seems to be causing issues with how typography is used in Global Styles.
Instead of overwriting each font size preset with the same value, this overrides each font size setting to the same preset (
small).This also removes the font family setting for
core/heading, as this doesn't seem to be required anymore and it makes managing the font families from Global Styles less confusing.Fixes #278.