DataViews: Move Spinner and No results text at the top. #67731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: -7 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
afercia
force-pushed
the
fix/dataviews-move-spinner-no-results-to-top
branch
2 times, most recently
from
78e4c6c to
dc23356
Compare
|
Flaky tests detected in dc23356. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12273604610
|
|
@WordPress/gutenberg-design I'd appreciate a review, when you have a chance. |
|
Not a strong opinion but I think the layout feels more balanced when centrally aligned. Is there another way to solve the issue, maybe a larger spinner, and including an icon/description when there are no results: 
|
|
I'd agree, I think there may simply be a dialectical disagreement on what proximity in the UI means. In both of these cases, these are finite panels that do not endlessly scroll off into infinity. They are centered in each of those panels, and are thus in proximity of those panels. |
Actually no, it's not about language semantics. I'd appreciate design feedback to take into consideration the devices and tools users actually use. Users who use screen magnification at very high zoom levels will struggle to understand there is some important information way far from the controls in use. Please refer to https://core.trac.wordpress.org/ticket/40822 to get more familiar with the underlying problem. This is an accessibility issue, not a visual balancing issue. Thanks. |
|
Maybe adding a bit more space at the top would improve the balance? Here's a screenshot of what it looks like in core. Screenshot: When no theme is found
In any case, I think the text could be improved. |
To better illustrate, I took the time to videorecord what the user experience looks like when using a magnification tool at a high zoom level. I'd expect contributors to this project to be familiar with all the technologies and devices WordPress aims to support to be as accessible as possible. Magnification tools are one of them. Contributors that use macOS can try the Zoom tool that is built in the operating system. It can be enabled from the system preferences and provides keyboard shortcuts to toggle on/off, increase and decrease the zoom level. When using these tools, users see only a portion of the screen. When important information is shown unnecessarily far from the current zoomed-in screen portion, that information may be completely lost. The argument that vertically centering is more 'balanced' is only for aesthetic reasons and doesn't take into account the functional issue any UI must address when it comes to the concept of proximity. I'd encourage contributors to actually try a magnification tool to better understand the issue this PR aims to solve. On macOS, such a tool is there, a few clicks right away from you. Please consider that in the videorecording below I'm using a moderate zoom level. I've seen users actually use an even higher zoom level, which makes the actual visible part of the UI even smaller. proximity.at.high.zoom.level.mp4 |
|
FWIW, there are designs and a discussion about an improved empty state in DataViews in #61442. |
|
As an example of a pretty largely used app on the Web, Gmail does place 'no results' and other important information at the top of the page, in proximity of other controls. For good reasons:
|
|
Adding one more consideration: there are places in the editor where such informational messages are displayed at the top of the panel. For example in the Inserter > Blocks / Patterns / Media, the 'no results' message is at the top. As such, the vertically centered alignment appears to be a design inconsistency, besides being not accessible. Screenshot:
@WordPress/gutenberg-core I'd appreciate a review, when you have a chance. Edit: |
afercia
force-pushed
the
fix/dataviews-move-spinner-no-results-to-top
branch
from
dc23356 to
1196287
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67730
What?
Moves the dataviews Spinner and 'No results' text at the top of the list panel.
Why?
Important information should be shown in proximity with the UI it relates to.
Low vision users, screen magnifier users, may entirely miss light shapes or small text shown in the middle of a big white space.
How?
Removes the flex-grow propertuy that was responsible to make this content vertically centered.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast