Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: Move Spinner and 'No results' at the top #67730

Open
2 of 6 tasks
afercia opened this issue Dec 9, 2024 · 0 comments · May be fixed by #67731
Open
2 of 6 tasks

DataViews: Move Spinner and 'No results' at the top #67730

afercia opened this issue Dec 9, 2024 · 0 comments · May be fixed by #67731
Assignees
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Dec 9, 2024

Description

When the DataViews is fetching data to show, it shows a Spinner. When there are no results, it shows a 'No results' text.
Both are shown vertically centered, in the middle of the panel.
The results are, of course, shown at the top.

While displaying content in the middle of a (mostly) empty panel may look more 'elegant' and balanced at first, it's not ideal for accessibility:

  • As a low vision user, I may entirely miss the Spinner. It's a very light gray shape in the middle of a big white space, which is very difficult to notice for low vision users.
  • Same for the 'No results' text: it's a small text in the middle of a big white space.
  • As a screen magnifier user, I would expect important information to be shown in proximity of other controls. I may be using a very high zoom level focusing on the search and filter controls at the top of the panel and entirely miss content that is shown far from the main UI controls.

I'm not sure whether there are specific design reasons to show this content in the middle of the panel other than aesthetic reasons. Anyways, I'd like to propose to move it at the top, immediately below the search and filter

Image

Step-by-step reproduction instructions

  • Go to the Site Editor > Pages
  • Obseerve that, while pages are being fetched, a Spinner is shown in the middle of the white panel.
  • Click a page type that doesn't return any result, e.g. make sure you don't have any 'Private' page and click Private.
  • Observe that a 'No results' message is shown in the middle of the white panel.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@afercia afercia added [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. labels Dec 9, 2024
@afercia afercia self-assigned this Dec 9, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant