ResizableBox: Change tooltip background to match other tooltips #42800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: +170 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Jul 29, 2022
andrewserong
approved these changes
Aug 1, 2022
There was a problem hiding this comment.
Thanks for following up @aaronrobertshaw, good to get this consistent!
Double-checked that the COLORS.gray[ 900 ] matches $gray-900 used in the Tooltip component 👍, and it's looking good in the editor:
LGTM ✨
|
Nice one. I wonder: should the tooltip sit in a consistent place too? They're useful for both cover and spacer, but isn't clear to me why one is fixed and the other is floating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
ResizableBoxto match the primaryTooltipcomponent and others such as theRangeControl.Why?
Consistency is good?
This addresses a suggestion that arose through the review of #23522. We can easily close this if there is a design rationale to have differing background colors for tooltips.
How?
ResizableBoxtooltip's background color to the sameCOLORS.gray[ 900 ]value as theTooltipcomponent.Testing Instructions
Tooltip,RangeControletc.Screenshots or screencast
Storybook Examples
Screen.Recording.2022-07-29.at.4.56.58.pm.mp4
Screen.Recording.2022-07-29.at.4.57.33.pm.mp4
Editor Demo
Screen.Recording.2022-07-29.at.5.19.10.pm.mp4
Screen.Recording.2022-07-29.at.5.11.08.pm.mp4