Cover: Show Resize Tooltip on Drag #23522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsJonQ
added
[Type] Enhancement
ItsJonQ
requested review from
ajitbohra,
chrisvanpatten,
Soean,
talldan and
youknowriad
as code owners
|
Size Change: +56 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Jul 7, 2020
ZebulanStanphill
added
the
Needs Accessibility Feedback
aaronrobertshaw
force-pushed
the
update/cover-resize-tooltip
branch
from
20c008e to
be0401e
Compare
aaronrobertshaw
removed
the
Needs Accessibility Feedback
ramonjd
approved these changes
Jul 29, 2022
andrewserong
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Thanks for updating this one @aaronrobertshaw! This is testing nicely for me in the editor. I noticed that the background color of the Tooltip appears to be different to Tooltips used elsewhere in Gutenberg, but it appears to be due to the ResizableBox's Tooltip styles (on this line?). It might be good to make it consistent with other Tooltips, but not a blocker for merging in this one, I don't think 👍
LGTM! ✨
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update enables the Resize tooltip for the Cover block. It appears below the cover block when dragging.
How has this been tested?
Tested in local Gutenberg
npm run devChecklist: