[RNMobile] Added auto opening of media upload options to Gallery block v2 #36757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +30 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
2 tasks
jd-alexander
added
Mobile App - i.e. Android or iOS
fluiddot
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Good catch @jd-alexander 🏅, LGTM 🎊 !
Tested on Simulator iPhone 12 Pro Max (iOS 14.5) and Samsung Galaxy S20 FE 5G (Android 10).
Thanks for the review @fluiddot 🙇🏾 |
jd-alexander
deleted the
rnmobile/gallery-block-v2-auto-open-bottom-sheet
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg-Mobile PRwordpress-mobile/gutenberg-mobile#4277Description
In #25940 the
autoOpenMediaUploadfunctionality for the Gallery block was removed in the v2 implementation that allows the Gallery block to be a wrapper around Image blocks utilizing InnerBlocks.This PR reintroduces this functionality since it is currently supported by v1, and is causing inconsistency with the different WordPress sites that utilize the Gallery block functionality, as self-hosted sites and non self-hosted sites are utilizing the different versions of the Gallery block.
How has this been tested?
Pre-requisite
Utilize a Simple Site for these tests.
Screenshots
Before
Screen.Recording.2021-11-22.at.8.41.06.PM.mov
After
Screen.Recording.2021-11-22.at.8.50.58.PM.mov
Types of changes
The changes introduce
MediaPlaceholderfunctionality fromv1edit.jsto the currentedit.js.Checklist:
*.native.jsfiles for terms that need renaming or removal).