-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove navigation block styles #23678
Conversation
This feels a solid improvement. Lots of red, and overall just a better experience front and backend, we're really getting closer: It does remove light and dark mode. But given that those could easily be inherited by the theme itself, or even be customized using the color tools if need be, seems worth it. 👍 👍 on a design point of view, and CSS code looks good too. Happy to approve, but since it's a breaking change, I assume it will need a dev note or changelog entry or both? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Removing the styles doesn't cause existing Navigation blocks out in the wild to no longer load. They will appear different, which is a breaking change, but since the Navigation block is experimental I think this is okay.
25b1729
to
fd421ef
Compare
Size Change: +5.43 kB (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
Description
Solves #22327 where we concluded the navigation block styles are not useful and should be removed.
How has this been tested?
Screenshots
Types of changes
Breaking change - it will affect all existing styled blocks out in the wild.
Checklist: