Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Navigation block ] Add transparent background for main block #22327

Closed
draganescu opened this issue May 13, 2020 · 6 comments
Closed

[ Navigation block ] Add transparent background for main block #22327

draganescu opened this issue May 13, 2020 · 6 comments
Labels
[Block] Navigation Affects the Navigation Block Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@draganescu
Copy link
Contributor

When a user adds a Nav block to their Header (in the near future), they'll likely add the Nav block on top of a solid color Header. It is also likely they'll want the background color of the Header to show through the Navigation block. I foresee this being a highly common experience based on web patterns out there.

Now, any elements that are z-indexed on top of the Nav block (ie. submenus) should definitely have a background color. I'm totally in favor of this, because it feels like this is the only time where we experience a z-indexing issue of content on top of other content.

Here's a quick diagram to help communicate my direction.

81745906-78a0e800-945a-11ea-8e10-b91917dd4049

The user can always add a background color to the block with the Color Settings.

cc @mapk

@draganescu draganescu added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block labels May 13, 2020
@paaljoachim
Copy link
Contributor

paaljoachim commented May 13, 2020

Good idea Andrei @mapk

I totally agree. Top menu items do not need a menu background color. As it would inherit the header background color. (Can add a color in the sidebar.)

Sub menu items do need a background color. If the submenu overlaps content below the sub menu (without it having a background color) items/links would get mixed in with the content below. Having a background color to start out with avoids the messiness of overlapping content below the menu. (Can change the background color in the sidebar.)

@mapk
Copy link
Contributor

mapk commented May 14, 2020

Thanks for creating an issue, @draganescu!

@mapk mapk added the Needs Dev Ready for, and needs developer efforts label May 14, 2020
@adamziel
Copy link
Contributor

adamziel commented Jun 9, 2020

One of the challenges here is figuring out how the style preview should look like:

Zrzut ekranu 2020-06-9 o 13 13 04

...that is, if these styles still make sense once the toolbar is transparent by default. Maybe they could be just removed.

@alaczek
Copy link

alaczek commented Jun 17, 2020

Maybe they could be just removed.

Yes, that would be preferable. These two styles don't provide any special functionality over color settings already available for navigation block.

@mapk
Copy link
Contributor

mapk commented Jun 29, 2020

I second (third?) the removal of these styles. 😄

@adamziel
Copy link
Contributor

adamziel commented Jul 7, 2020

This is now addressed with #23678

@adamziel adamziel closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants