RichText: Documented missing parameters for isEmpty and isEmptyLine #23338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javidalkaruzi
requested review from
ellatrix,
etoledom and
SergioEstevao
as code owners
ellatrix
reviewed
Jun 22, 2020
ellatrix
reviewed
Jun 22, 2020
ellatrix
reviewed
Jun 22, 2020
Co-authored-by: Ella van Durpe <[email protected]>
Co-authored-by: Ella van Durpe <[email protected]>
Co-authored-by: Ella van Durpe <[email protected]>
ellatrix
reviewed
Jun 23, 2020
ellatrix
reviewed
Jun 23, 2020
added 4 commits
June 26, 2020 03:41
…hub.com:javidalkaruzi/gutenberg into fix/rich-text-src-is-empty-jsdoc-missing-params
|
Thank you @javidalkaruzi for your contribution. It looks like those issues were resolved in different PR. I'm closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #22907.
Description
Fixed the JSDoc warnings in file packages/rich-text/src/is-empty.js
6:1 warning Missing JSDoc @param "value.text" declaration jsdoc/require-param
10:0 warning Missing @param "value.text" jsdoc/check-param-names
18:1 warning Missing JSDoc @param "value.text" declaration jsdoc/require-param
18:1 warning Missing JSDoc @param "value.start" declaration jsdoc/require-param
18:1 warning Missing JSDoc @param "value.end" declaration jsdoc/require-param
22:0 warning Missing @param "value.text" jsdoc/check-param-names
22:0 warning Missing @param "value.start" jsdoc/check-param-names
22:0 warning Missing @param "value.end" jsdoc/check-param-names
✖ 8 problems (0 errors, 8 warnings)
0 errors and 4 warnings potentially fixable with the
--fixoption.How has this been tested?
npm run lint-js packages/rich-text/src/is-empty.js
Types of changes
Bug fix