-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LatestPosts] Don't trim manual excerpts #20432
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
February 25, 2020 10:42
Size Change: +12 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
draganescu
force-pushed
the
add/respect-manual-excerpt-latest-posts
branch
from
March 9, 2020 07:50
00a371d
to
a9d3ffe
Compare
jorgefilipecosta
approved these changes
Mar 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked well on my tests 👍
jorgefilipecosta
added
[Type] Bug
An existing feature does not function as intended
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
labels
Mar 9, 2020
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 10, 2020
* adds raw excerpt to the LatestPosts block and respects manual excerpts * removed the reset to raw excerpt
jorgefilipecosta
pushed a commit
that referenced
this pull request
Mar 10, 2020
* adds raw excerpt to the LatestPosts block and respects manual excerpts * removed the reset to raw excerpt
jorgefilipecosta
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #20327 Based on input from #20313
This PR makes the
LatestPosts
block respect manual excerpts by showingpost.excerpt.raw
if it exists - without trimming it.How has this been tested?
Tested locally by:
Show post content
->Excerpt
andExcerpt length
to 10 words/Screenshots
Types of changes
Non breaking changes to the
LatestPosts
block edit function.