Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ LatestPosts ] Display full manual excerpts in the editor #20327

Closed
draganescu opened this issue Feb 20, 2020 · 0 comments · Fixed by #20432
Closed

[ LatestPosts ] Display full manual excerpts in the editor #20327

draganescu opened this issue Feb 20, 2020 · 0 comments · Fixed by #20432
Assignees
Labels
[Block] Latest Posts Affects the Latest Posts Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@draganescu
Copy link
Contributor

draganescu commented Feb 20, 2020

Is your feature request related to a problem? Please describe.
Manual excerpts should not be truncated, nether in the editor nor in the rendered content.

Describe the solution you'd like
#20313 implements a sample excerpt_length filter which allows the server side rendering of the LatestPosts block to respect how excerpts are currently handled by WordPress.

As discussed in the design channel on Slack we should stick to the following process:

  • blocks that work with excerpts, right now PostExcerpt and LatestPosts
  • should default to the global excerpt setting (set by the excerpt_length) filter
  • but have a local setting
  • which only affects their rendered content
  • but only generated excerpts
  • manual excerpts should be rendered integrally, independent of what the excerpt_length setting is.

This behavior is both consistent to how WordPress currently handles excerpts and also with what a user would expect from the system.

@draganescu draganescu added [Type] Enhancement A suggestion for improvement. [Block] Latest Posts Affects the Latest Posts Block labels Feb 20, 2020
@draganescu draganescu added this to the Future milestone Feb 20, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Latest Posts Affects the Latest Posts Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant