Try: Fix cropped focus ring in block library #17215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
requested review from
ellatrix,
talldan and
youknowriad
as code owners
kjellr
approved these changes
Aug 27, 2019
There was a problem hiding this comment.
Thanks, @jasmussen. This seems like a relatively solid fix for now. The main issue I see is that the hover state of one item can bump right up against the focus state of another now:
I don't have any immediate ideas for that... perhaps a transparent border or something? But if we can't figure that out, I think this is still an improvement, so probably fine to merge as a fix for now.
|
Thanks, I think that's a better state than master, a better holdover :) |
|
Thanks for this @jasmussen! Sorry for the breakage. 😞 |
|
Don't worry about it! |
gziolo
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe fixes #17094 and maybe fixes #17168 too.
There's focus ring on blocks in the block library and the switcher. These are cropped when blocks are near the edges, due to an overflow: hidden;. This PR attempts to fix that with a deadpan negative margin. Will it work? This is where YOU come in!
Before:
After: