Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choosing Block | Focus Overflow Hidden #17094

Closed
BenjaminZekavica opened this issue Aug 19, 2019 · 0 comments · Fixed by #17215
Closed

Choosing Block | Focus Overflow Hidden #17094

BenjaminZekavica opened this issue Aug 19, 2019 · 0 comments · Fixed by #17215
Assignees
@jasmussen
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@BenjaminZekavica
Copy link
Member

In the new version of the master I found the new Block Choose Feature. I think it's great and nice to have! But if I want to choose one Block, than the focus of the Block is active.
But here is hidden. Here two screenshots of this bug.

On the left side

Bildschirmfoto 2019-08-19 um 22 21 50

On the right side

Bildschirmfoto 2019-08-19 um 22 26 32

I tested with some installations without plugins (Only the current Github version of Master) and with the new 2019th WP Basic Theme. If I swich the themes this bug is same :(
@mtias mtias mentioned this issue Aug 21, 2019
Closed
@mtias mtias added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended labels Aug 21, 2019
jasmussen added a commit that referenced this issue Aug 27, 2019
@jasmussen
Try: Fix cropped focus ring in block library
4f38db6 
Maybe fixes #17094 and maybe fixes #17168 too.

There's focus ring on blocks in the block library and the switcher. These are cropped when blocks are near the edges, due to an overflow: hidden;. This PR attempts to fix that with a deadpan negative margin. Will it work? This is where YOU come in!
@jasmussen jasmussen mentioned this issue Aug 27, 2019
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 27, 2019
jasmussen added a commit that referenced this issue Aug 27, 2019
@jasmussen
Try: Fix cropped focus ring in block library (#17215)
51ec639 
Maybe fixes #17094 and maybe fixes #17168 too.

There's focus ring on blocks in the block library and the switcher. These are cropped when blocks are near the edges, due to an overflow: hidden;. This PR attempts to fix that with a deadpan negative margin. Will it work? This is where YOU come in!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try: Fix cropped focus ring in block library WordPress/gutenberg
3 participants
@mtias @jasmussen @BenjaminZekavica