Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machinery: Add DeepL support for glossaries #10519

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

nijel
Copy link
Member

@nijel nijel commented Nov 30, 2023

Proposed changes

  • Add generic mixin to handle service side glossaries
  • Implement DeepL integration

Fixes #7086
Fixes #10468
Built on top of #10516

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 5.3 milestone Nov 30, 2023
@nijel nijel self-assigned this Nov 30, 2023
@nijel nijel requested a review from orangesunny as a code owner November 30, 2023 15:22
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: Patch coverage is 82.29167% with 17 lines in your changes missing coverage. Please review.

Project coverage is 90.87%. Comparing base (dd88721) to head (96aac97).
Report is 4724 commits behind head on main.

Files with missing lines Patch % Lines
weblate/machinery/base.py 73.91% 8 Missing and 4 partials ⚠️
weblate/machinery/deepl.py 84.84% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10519   +/-   ##
=======================================
  Coverage   90.87%   90.87%           
=======================================
  Files         546      546           
  Lines       56574    56664   +90     
  Branches     9010     9028   +18     
=======================================
+ Hits        51409    51493   +84     
- Misses       3579     3586    +7     
+ Partials     1586     1585    -1     
Files with missing lines Coverage Δ
weblate/machinery/tests.py 99.84% <100.00%> (+<0.01%) ⬆️
weblate/machinery/deepl.py 91.76% <84.84%> (-4.73%) ⬇️
weblate/machinery/base.py 91.02% <73.91%> (-2.09%) ⬇️

... and 2 files with indirect coverage changes

- Add generic mixin to handle service side glossaries
- Implement DeepL integration

Fixes WeblateOrg#7086
Fixes WeblateOrg#10468
@nijel nijel merged commit 6efd08c into WeblateOrg:main Dec 1, 2023
@nijel nijel deleted the deepl-glossary branch December 1, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glossary support for the DeepL service Maintain glossary terms during automated translation.
1 participant