Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machinery: Include glossary in OpenAI translations #10516

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

nijel
Copy link
Member

@nijel nijel commented Nov 30, 2023

Proposed changes

Issue #7086

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 5.3 milestone Nov 30, 2023
@nijel nijel self-assigned this Nov 30, 2023
@nijel nijel marked this pull request as ready for review November 30, 2023 13:39
@nijel nijel requested a review from orangesunny as a code owner November 30, 2023 13:39
@nijel nijel enabled auto-merge (rebase) November 30, 2023 13:39
@nijel nijel force-pushed the mt-glossary branch 2 times, most recently from 13d57d9 to 098f15c Compare November 30, 2023 14:33
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #10516 (a4637ab) into main (3537b3d) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 88.23%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10516      +/-   ##
==========================================
- Coverage   90.89%   90.88%   -0.01%     
==========================================
  Files         546      546              
  Lines       56509    56574      +65     
  Branches     8998     9010      +12     
==========================================
+ Hits        51362    51418      +56     
- Misses       3569     3573       +4     
- Partials     1578     1583       +5     
Files Coverage Δ
weblate/checks/tests/test_checks.py 97.63% <100.00%> (+0.07%) ⬆️
weblate/glossary/tests.py 100.00% <100.00%> (ø)
weblate/trans/models/project.py 92.56% <100.00%> (+0.09%) ⬆️
weblate/machinery/openai.py 81.81% <80.00%> (-0.80%) ⬇️
weblate/glossary/models.py 87.50% <84.21%> (-2.06%) ⬇️

... and 1 file with indirect coverage changes

@nijel nijel disabled auto-merge November 30, 2023 17:56
@nijel nijel merged commit dd88721 into WeblateOrg:main Nov 30, 2023
@nijel nijel deleted the mt-glossary branch November 30, 2023 17:56
@nijel nijel mentioned this pull request Dec 1, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant