Prettify section names #638
Conversation
|
|
||
| ### Indirect Function Table section | ||
| ### Indirection section |
|
"Type": Are there plans to use this section for types other than function types? If not, "types" is over-general and confusing, and leaving it as "Signatures" would be better. "Function": How about "Declaration"? "Code", "Data": I prefer "Function Bodies" and "Data Segments". Characters are cheap in this context, and being more descriptive helps newcomers as well as people who have focuses besides the wasm binary format. |
|
I'm not sure these strings, whatever their value, will appreciably help anyone stepping through the binary in a hex editor. So I like the terseness (and lower case). |
|
@sunfishcode, yes, we anticipate other uses of the types section, e.g. consider user-defined struct types in the future. This ties in with #640. "Declarations": hm, not sure, as most other sections declare things, too. Re descriptiveness: agreed with Luke. @lukewagner, changed |
|
Heh, true; that PR would add an |
|
@lukewagner, or perhaps we should just use singular for all section ids, like we do in prose? |
|
True; the 's' isn't really adding a lot of value. |
|
Changed to singular. |
|
Any objections landing this? |
|
lgtm |
| * [Names](#names-section) section | ||
| * [Export](#export-section) section | ||
| * [Start](#start-section) section | ||
| * [Code](#code-section) section |
|
lgtm |
1 similar comment
|
lgtm |
* Merge pull request #648 from WebAssembly/current_memory Add current_memory operator * Reorder section size field (#639) * Prettify section names (#638) * Extensible encoding of function signatures (#640) * Prettify section names * Restructure encoding of function signatures * Revert "[Binary 11] Update the version number to 0xB." * Leave index space for growing the number of base types * Comments addressed * clarify how export/import names convert to JS strings (#569) (#573) * When embedded in the web, clarify how export/import names convert to JS strings (#569) * Fixes suggested by @jf * Address more feedback Added a link to http://monsur.hossa.in/2012/07/20/utf-8-in-javascript.html. Simplified the decoding algorithm thanks to Luke's feedback. * Access to proprietary APIs apart from HTML5 (#656) * comments * Merge pull request #641 from WebAssembly/postorder_opcodes Postorder opcodes * fix some text that seems to be in the wrong order (#670) * Clarify that br_table has a branch argument (#664) * Add explicit argument counts (#672) * Add explicit arities * Rename * Replace uint8 with varint7 in form field (#662) This needs to be variable-length.
[Retargeted #635 to 0xB branch.]
As suggested in #623. Better suggestions for some of the names are welcome.