-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corrected line endings (LF) #438
corrected line endings (LF) #438
Conversation
@cfoellmann Is there any chance that #367 would solve this on a local level rather than in the repo? I'm no good with line endings :) Also - I think the permissions on these files are best left at |
I tested #367. If it worked all the non-LF files should pop up as changed after the .gitattribute change. |
9c85a03
to
2ece9a1
Compare
2ece9a1
to
c2e1e66
Compare
#367 is working after all. This whole issue is because Git on Win just decides to use its own line endings for whatever reason because it has to decide (auto). When I download the zip via GitHub the files have the right line endings 👿 For me it only works when I clone the remote again with the new .gitattribute. Git on Win does not recognize the rule change. |
#430 seems to be working as good as this. |
Cool, this is good to know. I think merging #367 may be the right answer. I was hesitant at first because I'm not sure if changing the line endings on all the files was a big deal, but it may be ok. I'm going to leave this open for now, but merge #367. @cfoellmann, thanks for all your testing! |
Yes. Merge that one. Since all the files "run" on a Linux host within the vm LF should be the way to go in the first place. |
Closing this out, thanks for the work on this, @cfoellmann! |
This changes the line endings (from CR+LF to LF) of files connected to the guest cmd.
There are still some files like my.cnf that have Windows line endings which is not breaking anything but is not good either.
My tests show that this change results in
FIX Close #430
FIX Close #419
FIX Close #358
Improves #413