Force Unix line endings for all files #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @teraphy! I've never been good with line endings, which is why I've hesitated here. I'd be happy removing the (old) restriction on just .sh and .conf files, but I want to make sure doing this wouldn't cause another issue somewhere else. Another option could be to explicitly list the files without extensions that are copied to the virtual machine and need proper line ending handling. /cc @ericmann |
Closed
|
See conversation in #438, we're going to merge this in now as it should relieve Windows users. :) |
jeremyfelt
added a commit
that referenced
this pull request
Sep 3, 2014
Force LF line endings on all text files via .gitattributes
|
@jeremyfelt You're welcome! Glad to help out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New files that don't contain a script (.sh) or configuration (.conf) are converted over to using the CRLF endings due to the .gitattributes overriding local configurations. gitattributes is only taking into consideration the 2 file extensions. For example config/homebin contains no extension scripts.
This avoids confusion by not having to go that extra step of setting the global config which in turn avoids forcing all GitHub projects in a Windows environment to use Unix style line endings.