test: added missing tests for the Netpool analyzer (k8sgpt-ai#1016)

- Added a network policy allowing traffic to all pods. Resulting in additional failures in the results. Partially addresses: k8sgpt-ai#889 Signed-off-by: VaibhavMalik4187 <[email protected]> Co-authored-by: Alex Jones <[email protected]>
VaibhavMalik4187 · Mar 15, 2024 · f60467c · f60467c
1 parent 20892b4
commit f60467c
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/pkg/analyzer/netpol_test.go b/pkg/analyzer/netpol_test.go
@@ -136,6 +136,19 @@ func TestNetpolWithPod(t *testing.T) {
 
 func TestNetpolNoPodsNamespaceFiltering(t *testing.T) {
 	clientset := fake.NewSimpleClientset(
+		&networkingv1.NetworkPolicy{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "policy-without-podselector-match-labels",
+				Namespace: "default",
+			},
+			Spec: networkingv1.NetworkPolicySpec{
+				PodSelector: metav1.LabelSelector{
+					// len(MatchLabels) == 0 should trigger a failure.
+					// Allowing traffic to all pods.
+					MatchLabels: map[string]string{},
+				},
+			},
+		},
 		&networkingv1.NetworkPolicy{
 			ObjectMeta: metav1.ObjectMeta{
 				Name:      "example",
@@ -203,7 +216,7 @@ func TestNetpolNoPodsNamespaceFiltering(t *testing.T) {
 		t.Error(err)
 	}
 
-	assert.Equal(t, len(results), 1)
+	assert.Equal(t, len(results), 2)
 	assert.Equal(t, results[0].Kind, "NetworkPolicy")
 
 }